rnckp / starter-code_opendataswiss Goto Github PK

Hi Patrick,

Thanks for the nice repo(s)! My comments are for both (start-code_opendataswiss & start-code_ztzh) I really liked it so far.
It is well documented and easy to understand. The website (https://rnckp.github.io/starter-code_opendataswiss/) is very user-friendly and simply the best way to get to the notebooks, scripts.

I have some questions and maybe something for your backlog :)

• Is it really necessary, to load the packages "tidyverse" and "skimr" in the R markdown skripts? If possible, I would not use any package, that need to be installed by the users manually. Either get rid of additional packages, or install it with the function "install.packages()"
  You can load the csv data with the function "read.csv(.....". This function comes from the "utils" package. This package is usually installed and loaded for all R Users. To show the data after loading, "head(df)" and see the structure of the data "str(df)" are quite sufficient.
• Why did you use R markdown (.rmd) and not simply R script (.R)?
• Why is the functionallity between the notebook and the R markdown different? With the notebook, the user can see the missing values, which I really like. With the R Markdown you cannot see the missing values.

All in all, really good. I like the idea, to increase the simplicity to load the data of the data shop. Could be a new feature in the future :)

Kind regards
Adrian

Out of curiosity I wanted to explore the Baumkataster dataset (5b1d787e-b8cc-4a94-bdd9-8d834fb9c087.ipynb) and noticed, that it cannot be directly downloaded from https://www.stadt-zuerich.ch/geodaten/download/Baumkataster?format=10008, since the link does not point to a CSV file directly.

It is an html side, where some additional buttons have to be clicked and the csv file is generated afterwards.

Is there maybe a different API at stadt-zuerich.ch?