robin / lytabview

A customized Mac OS X Tab View with modern tab bar style

LYTabView

LYTabView is a customized Tab View with modernized tab bar style for Mac OS X.

Features

• Yosemite / El Capitan style tab bar
• Auto Layout
• Animation
• Reposition by drag and drop
• Tab context menu
• compatible with title bar

Animation

Drag and Drop

Used in title bar

Install

LYTabView supports Carthage. Add following line in Cartfile

github "robin/LYTabView"

Following the steps to add the framework into your project.

Or You can build it as a stand alone framework and add it into your project.

Usage

Check the Demo App for the usage

Author

Lu Yibin

License

LYTabView is available under the MIT license. See the LICENSE file for more info.

lytabview's Issues

Autolayout works strange for views inside tab

Hi Robin,

I noticed that the content of the tab view cannot autoresize itself horizontally.

It's quite easy to reproduce.

• Open labelViewController and make the label fill the space. Make the background of the label opaque, so you could see it.
  https://dl.dropboxusercontent.com/s/xy03gylv6dkvf4s/2016-07-14%20at%2021.46.png

If you run the application you'll see that the label fills all the vertical space but ignores the horizontal dimension. https://dl.dropboxusercontent.com/s/47yyawtv7hmfqp1/2016-07-14%20at%2021.48.png

I spent much time investigating the problem and found out that the problem is caused by NSStackView.
I also found out that it was introduced in the following commit:
aacb033 - fix tab bar hidding issue

I tried to fix it, but have no success so far. Do you have any idea why NSStackView causes such a behavior? Any advice (or link) would be welcome.

Thank you very much for your control. It's really awesome!

Regards,
Dan

Add removeNewTabButtonTarget and action

Hi @robin ,
We have

    open weak var addNewTabButtonTarget: AnyObject?
    open var addNewTabButtonAction: Selector?

for adding button purpose, how do you think if we add

   open weak var removeTabButtonTarget: AnyObject?
   open var removeTabButtonAction: Selector?

For trigger event when we close tab, because I want to trigger an event remove ViewController owner of view which was managed by tab item.
Implement NSTabViewDelegate seem clumsy.

Support vertical tab

Hi,

It's not a bug, but it would be great if we can support vertical tab.

Thanks.
Huy

Bug get selectedTabView

Hi @robin
I found an issue when get selected tabView when it in pack

    func selectedTabView() -> LYTabItemView? {
        if let selectedTabViewItem = self.tabView?.selectedTabViewItem {
            for tabView in self.tabItemViews() where tabView.tabViewItem == selectedTabViewItem {
                return tabView
            }
        }
        return nil
    }

It's always return nil because it is not in self.tabItemViews()
My work around,

    func selectedTabView() -> NSTabViewItem? {
        if let selectedTabViewItem = self.tabView?.selectedTabViewItem {
            for tabView in self.tabItemViews() where tabView.tabViewItem == selectedTabViewItem {
                return tabView.tabViewItem
            }
            for tabViewItem in self.packedTabViewItems where tabViewItem == selectedTabViewItem {
                return tabViewItem
            }
        }
        return nil
    }

But I think you don't want to change because it changed the interface

Issue when drag item

Drag item is a nice feature when we want to re-order tab item. But when item was packed, we can't drag it out. Any idea for this?
I just thought

1. We will move out it when selected in pack (move to last tab for example).
2. Using an other solution to pack tabs.

Sorry for annoying this morning, but I'm actually using it and got some trouble 😸

Support middle mouse click to close tab

Hi,
I have done this feature in my project and can create a pull request if you want.
Thanks,
Huy.

Issues when add target.

because

    open var addNewTabButtonAction: Selector?

https://github.com/robin/LYTabView/blob/master/LYTabView/LYTabBarView.swift#L141
Is strong, so if I add tabView as subview of View A and then set selector

 addNewTabButtonAction = A

The view will never release.

It would be great if we change it to

    open weak var addNewTabButtonAction: Selector?

I will give a pull request if you agree.
Thanks

Close tab to the Right

Hi @robin
It would be great if we can add a menu close tab to the right like Google Chrome does, I found it is a common way to close tab for end user.
I can make a pull request for this feature 💃

Huy.

Update Swiftlint convetions

Hi @robin, I'm glad to see that you have migrate to Swift 4.0, great work.
I have some warning in project that require update Swiftlint conventions:

For example:

animated:animated

Should be:

animated: animated

I can create a pull request for this.
Thanks,
Huy.

Bug close other Tabs

Hi @robin
Just found a bug, when tab was packed, it will not close when select close other tabs, it comes from tab in pack not actually in self.tabItemViews()
Huy

Improve behaviour

Hi Robin,

I have an issue when using TabView. Here is my gif.

I removed this line:

        set(newTitle) {
            titleView.stringValue = newTitle as String
//            self.invalidateIntrinsicContentSize()
        }

https://github.com/robin/LYTabView/blob/master/LYTabView/LYTabItemView.swift#L70
And it much better.

An other improve is set titleView breakmode to

        titleView.lineBreakMode = .byTruncatingMiddle

https://github.com/robin/LYTabView/blob/master/LYTabView/LYTabItemView.swift#L116

Support tooltip when hover mouse in tab item.

Hi,
can I create a pull request for this feature?
Thanks,
Huy.