Comments (6)
Having rosapi global makes sense insofar as it provides an API to global ROS facilities. I'm not sure what launching it inside a namespace would mean, semantically. Wouldn't /foo/rosapi
and /bar/rosapi
do exactly the same thing (i.e. provide the same response to identical service requests)?
If so, I see no need to run two (or more) instances of the node.
from rosbridge_suite.
I agree with @T045T. In most cases, I fully support local namespaces. But running two of this node will have no effect of make any sense as it truly is global.
from rosbridge_suite.
It is not a matter of having multiple instance of rosapi. It is about how to utilise node namespace. It expects that /rosapi namespace is always reserved for rosbridge and not used by any other node. It is pretty dangerous assumption and losing flexibility of library.
User should have a right to choose whether it is globally namespaced or locally namespaced. Is there any other reason rosapi should be global namespace?
from rosbridge_suite.
Good point about other nodes using the rosapi
namespace. But I still think rosapi
should treat its services like tf nodes treat the /tf
topic - always global, even if the node is launched inside a namespace. The user can still manually remap services if they conflict with other nodes.
To allow for that case, ROSLIB.Ros
should probably have a rosapiName parameter that defaults to "/rosapi"
from rosbridge_suite.
Your points are correct and I don't have actual usecase which proves necessity of namespace.
Let's keep this as global. I will re-open this when I find an usecase.
from rosbridge_suite.
This decision would help to close these issues.
#115
RobotWebTools/roslibjs#58
from rosbridge_suite.
Related Issues (20)
- Huge delay between server and client
- RosbridgeProtocol instance clean-up hangs when client disconnects under specific conditions. HOT 3
- services_glob allows all /rosapi services
- Cut a new release? HOT 3
- Service containing bounded array message HOT 1
- when send action goal , gets an error and tried to find action interface in the msg packages HOT 3
- address doesn't seem to have an effect in the websocket bridge
- Incompatible subscriber QoS when creating a subscription after a publisher HOT 3
- Asynchronous ROS2 Action Cancellation HOT 5
- 'float' object has no attribute 'get_fields_and_field_types' HOT 3
- Issues "catkin_making" rosbridge_suite in gentoo
- rosapi tries to parse `IDL` files as `msg` files and errors HOT 4
- OSError: [WinError 193] %1 is not a valid Win32 application HOT 2
- NaNs not handled correctly when in an array HOT 1
- Use pydantic instead of basic_type_check HOT 7
- cancel_action_goal results in action_result with no status
- Not working on Windows 11 with Foxy HOT 2
- Compilation give unknown CMake command "add_launch_test". HOT 1
- get_parameter_value not present in Jazzy for rosapi_node HOT 3
- Subscriber to topic throughput decrease eventually
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rosbridge_suite.