GithubHelp home page GithubHelp logo

Comments (6)

T045T avatar T045T commented on July 22, 2024

Having rosapi global makes sense insofar as it provides an API to global ROS facilities. I'm not sure what launching it inside a namespace would mean, semantically. Wouldn't /foo/rosapi and /bar/rosapi do exactly the same thing (i.e. provide the same response to identical service requests)?
If so, I see no need to run two (or more) instances of the node.

from rosbridge_suite.

rctoris avatar rctoris commented on July 22, 2024

I agree with @T045T. In most cases, I fully support local namespaces. But running two of this node will have no effect of make any sense as it truly is global.

from rosbridge_suite.

jihoonl avatar jihoonl commented on July 22, 2024

It is not a matter of having multiple instance of rosapi. It is about how to utilise node namespace. It expects that /rosapi namespace is always reserved for rosbridge and not used by any other node. It is pretty dangerous assumption and losing flexibility of library.

User should have a right to choose whether it is globally namespaced or locally namespaced. Is there any other reason rosapi should be global namespace?

from rosbridge_suite.

T045T avatar T045T commented on July 22, 2024

Good point about other nodes using the rosapi namespace. But I still think rosapi should treat its services like tf nodes treat the /tf topic - always global, even if the node is launched inside a namespace. The user can still manually remap services if they conflict with other nodes.

To allow for that case, ROSLIB.Ros should probably have a rosapiName parameter that defaults to "/rosapi"

from rosbridge_suite.

jihoonl avatar jihoonl commented on July 22, 2024

Your points are correct and I don't have actual usecase which proves necessity of namespace.

Let's keep this as global. I will re-open this when I find an usecase.

from rosbridge_suite.

jihoonl avatar jihoonl commented on July 22, 2024

This decision would help to close these issues.

#115
RobotWebTools/roslibjs#58

from rosbridge_suite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.