rodrigobdz / fish-apple-touchbar Goto Github PK

Describe the bug

The plugin does not seem to work when using fish with the vi-key-bindings (https://github.com/fish-shell/fish-shell/blob/master/share/functions/fish_vi_key_bindings.fish) and in insert mode.

To Reproduce
Steps to reproduce the behavior:

1. Enable vi-keybindings (fish_vi_key_bindings)
2. See that pressing the touchbar keys do not do anything (the bell is triggered though)
3. press "escape" to get into normal mode (out of insert mode)
4. press the touchbar key again and see that it works :-)

Expected behavior
I'd expect it to work in insert-mode too.

Desktop (please complete the following information):

• OS: macOS
• Version 10.14.6
• Fish: 3.0.2

Describe the bug
When I use fzf.fish, I am getting extra lines containing "1337;SetKeyLabel=" shown on the attached screenshot

To Reproduce
Steps to reproduce the behavior:

1. fisher install rodrigobdz/fish-apple-touchbar plugin
2. fisher install PatrickF1/fzf.fish
3. Ctrl+R

Expected behavior
I'd like this extra output seen in the screenshot to go away.
Would it be possible that fish-apple-touchbar is not cleaning its output correctly?
Or maybe I didn't configure it correctly (see my config in section Aditionnal Information)

Screenshots

Desktop (please complete the following information):

• OS: Mac Big Sur 11.4
• Fish: 3.3.0
• iTerm2: 3.4.6

Aditionnal Information
I configured fish-apple-touchbar like so:

cat  ~/.config/fish/conf.d/touchbar.fish
__fish_apple_touchbar_bind_key_custom 1 '👈' 'prevd' '-s'
__fish_apple_touchbar_bind_key_custom 2 '🗄 jump' 'cdh' '-s'

Describe the bug
When trying to update to the latest version, got the error above. May need refactoring?

Caused by jorgebucaran/fisher#651

Describe the bug
The touchbar only echos the key code to the terminal. The actual command does not run. I am guessing the binding is not happening like it should.

To Reproduce
Steps to reproduce the behavior:

1. Go to iterm2
2. Touch 'second view.'
3. Touch 'pwd'
4. Terminal displays 0Q

Expected behavior
The touchbar command should run.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: MacOS
• Version 10.15.6 (19G2021)

Additional context
I tried with Tide installed and uninstalled and the problem persisted. I have completely closed iterm2 as well. I am not sure where to start debugging this problem. I haven't worked with fish packages before. Any ideas where I should start looking? Thanks!