rohitsinghsalyan / polygeohasher Goto Github PK

Hi,

May I know what would be the appropriate data type for the geohash column name in my geojson file? Currently using string as the data type for my column, I am receiving the error in the photo attached.

Thank you.

Hi hi,

Thank you for this great library.

I'm curious if you have thought of using a "fill" method over the reduce method being used for the creattion of optimized list of geohashes?

I ask because the current approach can be very time consuming and I wonder if the other-way-around would speed things up.

All the best,

• Stefán

The readme mentions to make sure to include tests for proposed changes, sadly the project does not come with any as of right now. It seems the test directory is excluded in the .gitignore file. Can those be added to the project?

Just tried this repo. Works well, except for the following:

When trying the example, was getting a key error when attempting to create the geohash geometry dataframe (geo_df = ...).

Error was traced to misspelling of "opitimized_geohash_list", which should be "optimized_geohash_list"

Also, for consistency's sake, would stick with "optimize..." throughout the codebase rather than intermingle "optimize..." and "optimise.."

Best,

Mike