GithubHelp home page GithubHelp logo

Comments (5)

SteveMacenski avatar SteveMacenski commented on August 23, 2024

but all rosdistro distributions are pointing to the ros2 branch

That's just the doc link. But, yeah, that's one of the downsides of rolling's auto-release into new distributions, it just fills in the rolling branch's fields that might not be appropriate and are easy to not catch when running releases since its non-software. When I run releases, its on the proper distribution branch, not ros2.

I don't think for a package like this any ABI breaking change is acceptable for anything as critical as message filters, that should be only done for Jazzy and newer. I hope you're not saying that message_filters is breaking for Humble and Iron, right? That would be really bad for users, I know alot of folks that have customizations on message filters and those ABI/API policies are in place for a reason. Obviously welcome to change between distributions though so ros2 is game!

from perception_pcl.

ahcorde avatar ahcorde commented on August 23, 2024

New changes are only for rolling

from perception_pcl.

SteveMacenski avatar SteveMacenski commented on August 23, 2024

Oh yeah, then I think we're on board! Is the confusion just that the docs portion says ros2 from the rolling auto-release? I think otherwise, throw that bad boy in ros2 and we're good to go, humble/iron are on other branches. I just need to branch a jazzy off beforehand

from perception_pcl.

ahcorde avatar ahcorde commented on August 23, 2024

I can see in rosdistro that humble is pointing to ros2 and iron is also poiting to ros2 branch (not only documentation)

from perception_pcl.

SteveMacenski avatar SteveMacenski commented on August 23, 2024

Check out the actual releases https://github.com/ros-perception/perception_pcl/releases, the software targets its branches.

Keep in mind that when rolling forks into a new distribution, it populates the rolling fields. It looks like I / we didn't --edit to update the auxiliary items like docs / source locations to the updated pose, but rest assured, the software itself is all pointed to their appropriate branches for the build farm and binaries. That should be fixed for sure, but I bet there's a ton of packages with similar issues.

I'll rename the ticket for making that update since I think that's the real bug that you're reporting?

from perception_pcl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.