Comments (5)
I've got a patch pending which will clean this up before it is passed to tf2 from tf. If you call tf2 directly you will need to sanitize.
from geometry2.
@hershwg can you check that my patches in 1.10.3 of geometry work now?
from geometry2.
Sorry that I didn't check this sooner.
Actually there is a pretty major bug: if you call resolve("/map")
you
get back the empty string.
You need to change erase(0)
to erase(0,1)
in
strip_leading_slash()
. The second argument to string::erase() is the
number of characters to erase, which defaults to all of them.
I'm surprised the tests didn't catch this. Maybe they aren't being run?
Dave
On Wed, Jul 10, 2013 at 10:53 AM, Tully Foote [email protected]:
@hershwg https://github.com/hershwg can you check that my patches in
1.10.3 of geometry work now?—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-20760352
.
from geometry2.
The above comments refer to file tf/src/tf.cpp
.
On Thu, Jul 11, 2013 at 9:05 AM, Dave Hershberger [email protected]:
Sorry that I didn't check this sooner.
Actually there is a pretty major bug: if you call
resolve("/map")
you get back the empty string.You need to change
erase(0)
toerase(0,1)
in
strip_leading_slash()
. The second argument to string::erase() is the
number of characters to erase, which defaults to all of them.I'm surprised the tests didn't catch this. Maybe they aren't being run?
Dave
On Wed, Jul 10, 2013 at 10:53 AM, Tully Foote [email protected]:
@hershwg https://github.com/hershwg can you check that my patches in
1.10.3 of geometry work now?—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-20760352
.
from geometry2.
fixed erase syntax 37e978f94fab27e2e5596e96e7f3b675581a22e3
from geometry2.
Related Issues (20)
- Fail out of lookupTransform immediately if extrapolation into the past is required instead of waiting for timeout HOT 1
- Including tf2_geometry_msgs in a catkin package includes two versions of Eigen HOT 1
- Pose and Transform messages are redundant HOT 1
- ROS wiki tf2 tutorial page has errors
- sleep_duration of can_transform takes too much time HOT 1
- New release for Noetic HOT 13
- Wrong warning TF_REPEATED_DATA if 2 different transforms (with different frames) but same timestamp HOT 1
- tf_py.BufferCore not respecting cache_time argument HOT 2
- dotransform TransformStamped datatype not process child_frame_id HOT 2
- rostime_converter loses nanosecond precision
- Failing when Building for Humble with catkin errors
- Error while compiling using catkin for python3.8 HOT 1
- Using AngleShortestPath or getAngleShortestPath in python HOT 2
- Python tf2 buffer does not Detect Jumps in Time HOT 2
- Error in tf2 tutorial
- the parameter "time" not used in canTransform? HOT 1
- Treating a frame and a transform as the same is unclear without digging into source code
- ROS tf2 tutorial misleading content
- lookup_transform error when interpolating in the past HOT 1
- tf2 lookuptransform failed to get target_frame in rosbag play
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geometry2.