GithubHelp home page GithubHelp logo

Comments (4)

dirk-thomas avatar dirk-thomas commented on August 18, 2024

I am not sure I understand your exact use case and how it diverges from what is possible with the existing exit handlers but the design aims to enable implementing any logic using custom handlers.

from launch.

geoffviola avatar geoffviola commented on August 18, 2024

Here's the scenario. I have a launch file that starts a node and a custom parameter client. The parameter client will set the parameters and return with a zero exit code, if it ran properly. I do want the launch file to tear down if the error code is non-zero, because I don't want to run the node without the correct parameters. Currently, no exit_handler supports this scenario.

from launch.

dirk-thomas avatar dirk-thomas commented on August 18, 2024

Likely we haven't had this use case in any of the exiting demos and examples yet. A custom written exit handler should be able to fulfill this use case. You can either keep it in your package or create a pull request to contribute it to the launch package.

from launch.

clalancette avatar clalancette commented on August 18, 2024

I'm going to close this out since I closed out the PR that implemented this. Feel free to re-open if we want to keep this feature request.

from launch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.