ruimaciel / mropes

M's ropes library: a rope data structure library implemented in C

M's ropes library

M's ropes library: a rope data structure library implemented in C.

mropes's Issues

Issue with splitting

I have found a bug. It seems in mrope_split you favor pushing right side of the node first before pushing the left side. This is problematic because you do current_index += leaf_node->node.weight; which computes the relative index of the node on line rope.c:318 which acts on the first popped node(the right side). This has lead to some weird behavior as the index is relative to the left side. I have fixed this bug on one of my projects by replacing rope.c lines 248-259 with

                       if(branch_node->right != NULL) {
				error = mrope_stack_push(&node_stack,branch_node->right);
				if(error != MROPE_OK) {
					goto error_cleanup;
				}
			}
			if(branch_node->left != NULL) {
				error = mrope_stack_push(&node_stack,branch_node->left);
				if(error != MROPE_OK) {
					goto error_cleanup;
				}
			}