samourai-wallet / sentinel-android Goto Github PK

They have a bit different HD wallet structure, that is incompatible with the app - it would be fantastic to be able to add and track JoinMarket wallets, and it might bring you more users from the growing community of makers there.

Here's an overview on how their wallets work: https://github.com/JoinMarket-Org/joinmarket/wiki/Using-the-JoinMarket-internal-wallet

And a (python) script that manages wallets: https://github.com/JoinMarket-Org/joinmarket/blob/master/wallet-tool.py

As of version 2.5.4 which a I have installed the other day, there seems to be no way to display the value in fiat currency other than US dollar.

There are multiple comments on Google Play about the balance being wrong, and at least for my own balance I just found out what seems to be the culprit:

In the history of all tx, there's one where I sent bitcoin to a bech32 address. For that tx, instead of showing money being sent out, it shows the change amount as money received. This causes the balance to be off by exactly that amount.

I have protected Sentinel with a pin. When I open Sentinel and enter my pin, it shows the program.
But when I press the back button, it asks "Are you sure you want to exit Sentinel?" and choose "YES", I see the Android home screen again.
When I then tab/press the Sentinel icon, it opens up directly, but doesn't ask for my pin!

But if I close Sentinel and kill it by long pressing the home button and swipe Sentinel away, thus killing it via the task manager, then it will ask for my pin again.

I consider this incorrect behavior and it should've asked me for my pin every time I open Sentinel.

Transaction history does not refresh after removing wallet address from the watchlist. You have to restart the app.

Ability to specify a bitcoin node to connect to. Thank you

Accept Segwit XPUBs starting with "ypub" - see https://github.com/spesmilo/electrum/blob/0a648e2b1cdb7852d80c0626c62984ef01c1c7e9/lib/bitcoin.py#L50 for magic constants (0x049d7cb2 for segwit p2sh).

By using a different magic for Segwit XPUBs, you don't need to ask user what kind of XPUB is being scanned.

Suggestion: just detect automatically, don't ask user.

Right now, the app can show the amount of money of the wallet in $, getting the "street price" from localbitcoins.com or Bitfinex.

I would love being able to chose another reference site for the street price, so that we can get the price in €, or other fiat currency..

This is a very minor issue, but still: after adding a new watch-only HD wallet to watch, renaming it alternates between having no effect and killing the app.

To reproduce:

1. Add new xpub.
2. Rename it to something different.
3. Either nothing happens or app terminates with "App keeps closing" message.

I opened my sentinel right now and I saw I received 3 transactions of 0.5 cents and then a transfer of the same amount in 3 transactions. I closed and opened again and the transactions disappear, back to normal.

What happened? Just for security, I checked my real wallet (not only watched) and there are no new transactions.

I can't find the Sentinel app in fdroid although i have added the repository..
Only possibility for de-googled android users is to download apk directly but thats unfortunate in regards of updates...

Samourai recently dropped support for fiat exchange rates in favor of satoshis. I think it would make sense for Sentinel to follow suit.

Added a zpub segwit(bech32) wallet from electrum, but it failed to recognize this transaction:
93b2d7bb7cd23dfcf6af034914035dc71c1850a7ecc41fb0c87073219e3cd23a

It would be great having Tor support in Sentinel, working in a similar way Samourai does.

Failed to add Ypub addresses which have large number of transactions.

With no full transaction history there is very little I can do to debug it.

Trying to import a xpub or zpub from a coldcard wallet.
The balance always shows 0.

Currently neither seems possible. After trying to add a joinmarket wallet, this toast is shown on every app launch and there's nothing one can do about it:

Also, once the wallet has been added it cannot be renamed/re-added with a different name.

And if these features exist, please do improve discoverability on them, as I've spent a good 10 mins trying to find/bruteforce it ;).

So yeah, I import my XPUB of my SW account and it initializes fine, only for the fact that my balance stays at zero and I get no transaction history whatsoever.

I thought this was due to new SW XPUBS (I had to grab em from the Trezor beta wallet since they arent offered on the standar Trezor client), so I imported a legacy non SW xpub from my Trezor. The same thing happens.

Any clue?

It would be awesome if an option is added to open the blockchain explorer in a Chrome Custom Tab so I don't have to leave the app to view transactions.

This app is awesome by the way, keep up the great work!

Currency is now shown in 'sat' an I cannot change it back to 'euro'

After importing xpub/ypub from a Trezor, Sentinel shows the correct balances for all addresses derived from that key that had a balance before importing into sentinel. If after that you receive a transfer to one of the next unused addresses derived from that key, Sentinel never shows those transactions / balances. For a watch-only wallet, it fails to watch. I think the expected behaviour should be to look for transactions by looping through all the derived address until finding one with none, but this should be done every time you open the app, not when you import.

• I installed sentinel on my Android phone

• Went to "Network" panel (the radar icon top right)

• Pressed "ENABLE" next to "Dojo Full Node"

• Pressed "CONNECT TO EXISTING DOJO"

• A dialog shows up with the title "Connect to your Dojo",
  and some instructions that are truncated because the text
  does not fit in the dialog, and there is no scrollbar.

  I suspect there is a button I could press after the instructions,
  but because I can't scroll to it. I'm stuck.

generate an address (bech32), and upon changing the value of BTC to receive, the app would crash.

I realize that it has been a while since this project was active, but is there any way we can get the API servers back online? Legacy (xpub), and P2SH-Segwit (ypub) are working fine, but (zpub) is not. There were rumors on reddit that each zpub had to be white-listed by your backend API to work. Is this still the case?

Reproduction steps

1. Install Sentinal
2. Add 12xAll test vector zpub

• zpub6rszzdAK6RuafeRwyN8z1cgWcXCuKbLmjjfnrW4fWKtcoXQ8787214pNJjnBG5UATyghuNzjn6Lfp5k5xymrLFJnCy46bMYJPyZsbpFGagT

3. Compare to blockchair

I have discussed this issue in the email as well with Samourai team but i would like to create the issue on github so that i can track the fix and release.

Issue -
When i select “sweep private key” on top right corner then i do not get any alert or popup. It just straight go to the deposit screen.

Steps -

1. Add trezor ypub to sentinel
2. Tap toolbar and selected “sweep private key”
3. No option to scan private key. Only qr code and address with share button on top is available which is a deposit screen

Tested in Samsung s8 and Samsung a7

Would be great to support BIP48(undocumented) derivation path for multisig HW wallets.

Further info — https://www.reddit.com/r/TREZOR/comments/4gakr6/where_is_bip48_documented/

When using the Trezor wallet to show the xpub, sentinel can scan and import these. The balance is shown only for the non-segwit legacy accounts. The scanned xpubs from the new segwit wallets do not show any transactions on the sentinel app. I think you probably know this but did not see an open issue so created one.