Errors running tests since upgrading to v5 of `ember-qunit` about ember-cli-page-object

[ro0gr]

I've just published v2.0.0-beta.1. A noticeable change is that we've stopped importing adapters(previously known as private ExecutionContexts) eagerly, and now we require to import and set adapters manually in user land, see #511 for some more details. I believe this change should avoid the issue with the ember-native-dom-helpers, which you've mentioned @cah-briangantzler.

If there are any sub tasks

I'd really like us to add ember-qunit@5 to our test matrix. There was some initial effort already #516, but seems we still need to move it to the finish line, and target it to the v2-beta branch.
It'd be great, if someone could help with this and make sure ember-qunit@5 is really supported!

[ro0gr]

ember-qunit@5 support has been released as 1.17.5. Thanks everyone for making it happen! 🚀

[ro0gr]

Thank you guys for raising the issue and investigation!
Removal of old moduleFor integrations is definetily on their way.
Unfortunately, I'm a bit limited in time currently, but I'll try to find some time this weekend to publish the first beta of v2, which unlocks us to remove the old integrations "properly". Will keep updating the status here in the ticket.

[SergeAstapov]

@ro0gr I opened #529 which is relatively simple fix that could be released as patch version for ember-unit v5 compatibility without need to wait for v2 or upgrade to v2 beta.

[cah-brian-gantzler]

So the problem is a lot bigger than that. They really need to get away from using https://github.com/cibernox/ember-native-dom-helpers as well because that also does an import of ember-test-helpers/wait. We dont want to fix ember-native-dom-helpers either as it really is no longer needed.

Attempting to remove ember-native-dom-helpers lead to a host of tests breaking that would need rewritten.

In my experiments I also found that fillin will allow you to fill in a disabled element, when removing ember-native-dom-helpers and using fillin from @ember/test-helpers, fillin now fails when the element is disabled, which is the correct thing to do. This prevented me from using my applications tests to test ember-cli-page-object changes because my tests now fail because Im filling into a disabled element (I have to fix them as well now). There also seems to be a difference in visit, but I did not explore it as the changes just spiraled.

I am hoping one of the maintainers that know a lot more about how this is put together will find the time to fix this.

[cah-brian-gantzler]

If there are any sub tasks I can help with. Let me know.

[SergeAstapov]

Created a fix for ember-native-dom-helpers in cibernox/ember-native-dom-helpers#168