Comments (4)
ro0gr
commented on June 11, 2024
1
Wow, I didn't realize that refactoring does also fix this issue 😃 great to know!
from ember-cli-page-object.
NullVoxPopuli
commented on June 11, 2024
I'd PR a fix, but my system is out of file watchers, supposedly (but only in ecpo?) and won't start up ember-cli-page-object 🤔
from ember-cli-page-object.
ro0gr
commented on June 11, 2024
Ah, it seems to be reproduction for the #534. Thanks for figuring it out! A PR would be very welcome!
Regarding the watchers issue, I haven't noticed it ever before. I can only guess here. Do you do fresh install over the cloned project, w/o any linking?
from ember-cli-page-object.
NullVoxPopuli
commented on June 11, 2024
it actually looks like on master, this is already fixed?
https://github.com/san650/ember-cli-page-object/blob/master/addon-test-support/create.js#L213
the condition is inverted, but also the code entirely looks a bit different. 🤔 so.. idk what's going on yet.
I now wonder if I'm having yarn-workspace problems and I'm not actually using the latest ember-cli-page-object. O.o
yeah, so this was fixed here: 6dbdb9e#diff-7e9135d873a4889a025f4ed419cf7d3025a1fc38f7ec08bb1c7b3800c55a3483
which is included in 1.17.7.... ugh. yarn
from ember-cli-page-object.
Related Issues (20)
- Clicking on text with comma produces a deprecation warning HOT 1
- How to replace deprecated `is(':focus')`? HOT 3
- Errors running tests since upgrading to v5 of `ember-qunit` HOT 7
- Deprecation calls need to be updated for compat with Ember 3.24 HOT 2
- Incompatible with Embroider 's `staticAddonTestSupportTrees` optimized mode HOT 10
- Query Engines
- Assign is being referenced from @ember/polyfills. This prevents upgrade to Ember 4 HOT 4
- Update ember-cli-babel HOT 5
- migrate to v2 Addon Format HOT 4
- Types require allowSyntheticDefaultImports=true HOT 2
- Replace usage of ember-native-dom-helpers by @ember/test-helpers HOT 1
- is there a way to create recursive page object? HOT 2
- docs: clickable needs to be awaited HOT 2
- All imports must be declared as dependencies or peers HOT 3
- Fix support for @tsconfig/ember 3.0.0 error TS7016 HOT 6
- [Quest] Remove jquery
- get rid of `$.param(`
- `$.prop(`
- deprecate finders `scope` option
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cli-page-object.