Incompatible with Embroider 's `staticAddonTestSupportTrees` optimized mode about ember-cli-page-object

[ro0gr]

Keep pushing it slowly. I think I'd like to make it work on the v2 branch first, cause there should be just a bit less magic, and if there are some blockers, we're a bit safer to adjust it there.

Currently, it's blocked with some issues related tobuildEmberPlugins(, which we've started to use in the #531. Reported it to the ember-cli-babel for now(emberjs/ember-cli-babel#398).

[ro0gr]

A quick update. I've started looking into this. The first blocker appeared is TS tests. Created a ticket for this(embroider-build/embroider#691), Hopefuly, it'd be easy to fix.

[alexlafroscia]

That latter issue (the one about emberDeprecate) is something I ran into as well -- #540 should fix that part!

[patocallaghan]

@ro0gr no problem. I tried to initially put together a PR which added Embroider ember-try scenarios but it failed spectacularly 😃 As you mention it looked to be because of the old ember-cli/ember-cli-babel etc and I didn't want to boil the ocean 😅

@alexlafroscia thanks for figuring out the emberDeprecate issue in #540 🙌

[ro0gr]

Well, the day has come 🙂 Thanks for opening the Embroider topic!

I meant to test against it for a quite a long time, but didn't really know how to do it. I suspect an old ember-cli-babel@6 would be one of the first blocker for that. I'd give it a try by adding an ember-try scenario(ispired by ember-cli/ember-cli#9436), let's see how far we can go in scope of ec-page-object@v1.

[rwjblue]

I just debugged this with @thoov and @krisselden (working on one of our internal applications). The basic issue is that this code:

ember-cli-page-object/addon-test-support/-private/compatibility.js

Lines 43 to 51 in 82b7e85

	if (require.has('@ember/test-helpers')) {
	helpers = require('@ember/test-helpers');
	} else {
	helpers = {
	getContext() {
	return null;
	}
	};
	}

Is not understood by Embroider (with that staticAddonTestSupportTrees flag set to true). We end up hitting the else case in this conditional (and any others that use require.has like this) and then not finding the associated context.

[rwjblue]

The thing I'm not sure about here are if we actually have the same support constraints as were in place when this compatibility layer was introduced?

[rwjblue]

I think the things that are being done there could be implemented in terms of @embroider/macros 🤔

[ro0gr]

@rwjblue sorry for inconveniences. It takes a some longer to move it to the finish line, but we are going to solve it soon.

I think the things that are being done there could be implemented in terms of @embroider/macros 🤔

Maybe it could, though I haven't tried it and not sure if it requires ember-auto-import@2 to be installed to make it work(which would be a breaking change). In case if it's possible to do in a backward compatible way I'd be glad to accept such a PR. However, TBH, I suspect there might appear some other roadblocks for the proper embroider support, related to some tricks in the https://github.com/san650/ember-cli-page-object/blob/master/index.js, or what else stuff.

The current plan is to remove this compatibility layer completely for the next major release of ec-page-object, and make embroider supported properly.

[ro0gr]

This should be addressed now in the v2.0.0-beta.3