GithubHelp home page GithubHelp logo

Comments (12)

mybearworld avatar mybearworld commented on June 3, 2024 3

Then the quote is ambiguous anyways. Someone who doesn't know the abbreviation might actually think you're quoting the TOLORS user. This problem wouldn't exist if you'd explicitly say "The Official List Of Rejected Suggestions", which isn't a valid username.

from scratchaddons.

Samq64 avatar Samq64 commented on June 3, 2024 2

This feels like #4845 all over again where most people agree it's a nice feature to have but no one can agree where to put it.

from scratchaddons.

just-a-hriday avatar just-a-hriday commented on June 3, 2024 1

from scratchaddons.

just-a-hriday avatar just-a-hriday commented on June 3, 2024 1

I'll just open the pull request if you're fine with the idea, I can put the code into an existing addon later.

from scratchaddons.

Samq64 avatar Samq64 commented on June 3, 2024

This could be part of #4845.

from scratchaddons.

Secret-chest avatar Secret-chest commented on June 3, 2024

Putting both in more-links might not be a bad idea though. Both these addons serve the same purpose as more-links - they make things that could be links, but are not links, links.

more-links makes URLs links. Forum mentions makes forum usernames links to make it consistent with comments. This tweaks the site UI, and curator link also tweaks a really specific part of the UI that is completely unrelated. Merging makes no sense.

from scratchaddons.

Secret-chest avatar Secret-chest commented on June 3, 2024

Also, how we will handle non-user quote names? Like [quote=TOLORS]?

from scratchaddons.

just-a-hriday avatar just-a-hriday commented on June 3, 2024

Also, how we will handle non-user quote names? Like [quote=TOLORS]?

The best solution would be to not turn non-usernames into links.
My implementation only allows valid usernames, but I can't think of a way to check if the user actually exists.

from scratchaddons.

Secret-chest avatar Secret-chest commented on June 3, 2024

Maybe a TOLORS user exists, that's the problem. It would be very unpredictable. How do we know we're quoting TOLORS the post or TOLORS the user?

from scratchaddons.

WorldLanguages avatar WorldLanguages commented on June 3, 2024

Hmm, this is ok, but it's hard to know where it would fit...

from scratchaddons.

just-a-hriday avatar just-a-hriday commented on June 3, 2024

Hmm, this is ok, but it's hard to know where it would fit...

I've implemented it as a new addon, but I think it would fit well into more-links.

from scratchaddons.

Secret-chest avatar Secret-chest commented on June 3, 2024

Let's style it normally so it's unobtrusive for non-users.

from scratchaddons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.