seanchas116 / qtimgui Goto Github PK

[Problem]
According to imgui release v1.87 :
2022/02/29: We discovered a backward-compatibility regression in 18700:
Direct legacy reads from io.KeysDown[] won't work with new backends.
And in particular io.KeysDown[GetKeyIndex[XXX]) will buffer overflow in old and new backends.
You can refer to https://github.com/ocornut/imgui/issues/4921
[Solution]
Backend writing to io.KeyMap[], io.KeysDown[] -> backend should call io.AddKeyEvent()

Input Method Editors can't use in inputtext,but it's ok in gltf backend on windows.

I find the code in glfw backend ,need add something like this:

  #if defined(_WIN32)
      ImGui::GetMainViewport()->PlatformHandleRaw = (void*)glfwGetWin32Window(bd->Window);
  #endif

See https://github.com/blockspacer/qtimgui-wasm-port

Describe the bug

Currently the imgui mouse pos is updated whenever the widget window/window is active. But in the case of widgets windows it also makes sense to check the focus. Otherwise a mouse over the area can trigger hovering effects in imgui when the user is interacting with other QT widgets.

//... ImGuiRenderer.cpp
if (m_window->isActive()) // + also check focus in case of widget
{
    const QPoint pos = m_window->mapFromGlobal(QCursor::pos());
    io.MousePos = ImVec2(pos.x(), pos.y());
}
else
{
    io.MousePos = ImVec2(-1,-1);
}

To Reproduce
Have any widget like a combo box that expands over the widgets area when interacted.

Expected behavior
Imgui mouse pos should not be updated when the widget has no focus other widget has focus to avoid hovering triggers.

Desktop (please complete the following information):

• OS: Win10. Note that I am using imgui 1.89.2.WIP with docking plus some fixes for the keyboard, etc.

I'm on windows 10.
A lot of the button widgets don't respond to rapid left-clicks.

I found a bug in the event filter that blocks the QEvent::MouseButtonDblClick events from progressing to imgui.

If I add this to the eventFilter switch statement, the double click events are passed to imgui, and the buttons then respond to rapid left clicks.

You can test this by checking the demo "double click" debug field to make sure the events are getting to imgui. See below for source code change location, and test location.

I compiled and run your project, but a main window shown up, no imgui window, could you tell me what's wrong? I used visual studio 2015 to convert you .pro project to a vs project with qt-vs-tools-msvc2015-2.1.1， with Qt5.8 enviroment. thank you.

i actually hope this Dear ImGui can work under Qt4.86 (since one of my project is constructed under this). is it possible? thank you .

winston

Describe the bug
Incorrect background color for modal windows.

• Same as ocornut/imgui#4845 and others.
• Also referenced in the release https://github.com/ocornut/imgui/releases/tag/v1.86
• Similar fix as ocornut/imgui@c80e8b9

Note that I am using imgui 1.89.2.WIP with docking plus some fixes for the keyboard from #44

To Reproduce
Just open the modal popup window as shown in the screenshot.

Screenshots

Expected

I already got it working so will post a PR 😃 solving this specifically, no other changes

qtimgui does not seem to support multiple OpenGLWidgets

Describe the bug
Switch ImGui branch to docking branch then run demo, demo crashed, print assert meesage:

Assertion failed: (g.IO.KeyMap[n] >= -1 && g.IO.KeyMap[n] < ((int)(sizeof(g.IO.KeysDown) / sizeof(*(g.IO.KeysDown)))) && "io.KeyMap[] contains an out of bound value (need to be 0..511, or -1 for unmapped key)"), function ErrorCheckNewFrameSanityChecks, file imgui.cpp, line 8557.

Using master ImGui branch is ok, even I check out a new branch from docking and merge master, it also crashed, could you give me some help? Thank you.

Is it possible to use QtImGui with multiple QOpenGLWidgets sharing the same class? I'm calling QtImGui functions while QOpenGLWidget is underMouse() which prevents crashing but ImGui does not render in the other active viewports, only the first one.

The building and running environment is Qt5.13.2 for windows 10.

on Mac os. the contents on the window don't display normally. It display only when I drag the window to the top left corner of the big main window.

No rule to make target '../../qtimgui-master/imgui/imgui_draw.cpp', needed by 'debug/imgui_draw.o'. Stop.

Add package to https://www.qpm.io/

Probably #4 is not working well.

Hi, when using latest IMGUI , there is a 'error ' pop up dialog show up again and again. But runs fine under your version.
Would you fix it?
thanks.