shaneosullivan / gitmeme Goto Github PK

This is a great change that will make everything better

Hi, I'm enjoying using gitmeme over in https://github.com/desktop/desktop! (example) Thanks for making it!

I noticed today that the alt text generated by gitmeme is a bit clunky for screenreaders. For example:

is created by /nice and displays a "nice" gif, but the alt text says Created by gitme.me with /nice, which has an unnecessary preamble and an / right before the user search string, which means the screenreader will say "with forward slash nice" instead of "with nice".

According to WAI, the best text alternative is the impression the image is meant to give. Therefore, I propose that the alt text for gitme.me content be the user supplied search string.

(It would be nice to split the search string at _, since that seems to be the best way to do multi-word searches, but I think just using the search string by itself is a great improvement.)

Is it possible to add support for Gitlab (gitlab.com and self-hosted instances)?

Because, if so;

When you click sponsor, you get:

Some errors were encountered when parsing the FUNDING.yml file:

    Some users provided are not enrolled in GitHub Sponsors. Apply to Sponsors.

Learn more about formatting FUNDING.yml.

When I click "add new" it says "To add new memes you must be logged in." - but I am. Clicking login the first time, I log in, refresh the page, same behavior. Now clicking "log in" does nothing (because I'm logged in).

chrome and chromium

What do you think?

Light-gray on white is quite difficult to read:

Let's launch this!

I find gitmeme often replacing parts of urls or paths .. it should really only look for /whatever on a line by itself. And it should also ignore anything in a code block .