GithubHelp home page GithubHelp logo

observable-to-promise's Issues

Conversion of non-promises to promises is problematic for AVA

#1 Causes every argument to be converted to a via Promise.resolve(). That creates a small problem for AVA, since this line expects isPromise(fn) to be false if a function was passed in.

Also, the current behavior creates ambiguity, as:

observableToPromise([1,2]);

Produces an identical result to:

observableToPromise(Observable.of(1,2));

Allow gathering a specific amount of values instead of all of them

It would be useful if this module could only take a specific amount of values from an observable to achieve a similar purpose as p-event:

const observableToPromise = require('observable-to-promise');

(async () => {
	console.log(await observableToPromise.one(Observable.of(1, 2, 3, 4, 5)));
	//=> 1

	console.log(await observableToPromise(Observable.of(1, 2, 3, 4, 5), {maximumValues: 3}));
	//=> [1, 2, 3]
})();

// @sindresorhus

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.