C1001 internal compiler error in VS2017 about entt

[w1th0utnam3]

Cool. Yes, it is working now.

[skypjack]

Unfortunately it's an issue of VS compiler. I cannot do much for that. If you find a workaround that works on VS, I'd be glad to integrate it. I've not a copy of Windows on which to test it.

[w1th0utnam3]

Thank you for your reply. As I mentioned in the last lines of the initial post, using
: pools(Pool<Component>{dim}, Pool<Components>{dim}...)
instead of
: pools{Pool<Component>{dim}, Pool<Components>{dim}...}
does the trick for VS2017, i.e. not using the uniform initialization syntax for the tuple.

[skypjack]

Yeah, I got it. Feel free to put it in a PR. Anyway, I'd like to have a switch like #ifdef WIN32/#endif where WIN32 should be exported from cmake.

---

Meanwhile I added support for appveyor and I'm testing it. See branch AppVeyor. Hope it works for you. If it pass the tests, I'll integrate it on master.

[skypjack]

Ok, I pushed on branch appveyor and it works.
If you can confirm it, I'll merge the branch on master. Do not forget to build by using cmake, for it exports the expected variable WIN32.
Thank you. I'm looking forward for your feedback.

[w1th0utnam3]

Are you sure that you only want to enable this when cmake ran? As the registry, etc. is header only I didn't run it and instead directly included the headers.
Alternatives or extensions to your solution would be the macros _MSC_VER for the compiler version and _WIN32 and _WIN64 depending on the target defined by the Microsoft compiler.

[skypjack]

Actually I think cmake sets it up also when you run it through cygwin. Good point. _MSC_VER is more appropriate. Can you create a PR for that? Otherwise I'll update it in the afternoon.

[w1th0utnam3]

Makes sense, using `_MSC_VER` it's later possible to restrict this fix to older compiler versions when the bug is fixed. I could write a PR but unfortunately I'm not able do this before afternoon either.

…

________________________________ Von: Michele Caini <[email protected]> Gesendet: 23.05.2017 8:27 vorm. An: skypjack/entt Cc: Fabian Löschner; Author Betreff: Re: [skypjack/entt] C1001 internal compiler error in VS2017 (#1) Actually I think cmake sets it up also when you run it through cygwin. Good point. _MSC_VER is more appropriate. Can you create a PR for that? Otherwise I'll update it in the afternoon. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMXf4Hw7aqi1_Z874LkonpL01ris6-rhks5r8nxrgaJpZM4NivYx>.

[skypjack]

Found the time to update it and it works just fine on appveyor as expected.
If you can confirm it your side, I'll merge everything on master and close the issue.
Thank you very much.

[skypjack]

Upstream. Thank you.