skyplabs / python4yahdlc

Python binding of the yahdlc library

Hi there! 👋

My name is Paul aka Skyper.

Self-educated since my childhood, I am a technology and science lover with a deep passion for IT, InfoSec and open-source software and obsessed by automation. I write software, create learning contents about IT-related topics and hunt for bugs.

---

📰 Personal Blog | :elephant: Mastodon | :rocket: Malt | :busts_in_silhouette: LinkedIn | :bug: Open Bug Bounty | :key: Keybase

python4yahdlc's Issues

Use "Py_XINCREF()" and "Py_XDECREF()" when appropriate

Replace calls to Py_INCREF() and Py_DECREF() with Py_XINCREF() and Py_XDECREF() when appropriate.

From https://docs.python.org/3/extending/extending.html#null-pointers:

The macros Py_INCREF() and Py_DECREF() do not check for NULL pointers — however, their variants Py_XINCREF() and Py_XDECREF() do.

Add pyproject.toml file

Improve the packaging of the project by adding a pyproject.toml file as described in PEP 621.

For more information:

• https://packaging.python.org/en/latest/guides/making-a-pypi-friendly-readme/#validating-restructuredtext-markup
• https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use.

Monitor dependencies with Dependabot

Get Python versions from project file

Version 4.7.0 of the setup-python action allows getting the Python versions from a pyproject.toml file. This would remove the need to update the supported Python versions in multiple files. However, setup.cfg files are not supported, which implies transferring the content of setup.cfg to pyproject.toml.

Unable to install under windows

Hi,
I'm trying to use this library under windows machine, unfortunately installation using pip fails with:
ValueError: path '/home/travis/build/SkypLabs/python4yahdlc/lib/fcs16.c' cannot be absolute

When I tried to build the library manually (python3 setup.py install) I've noticed the source files (from lib and include directories) contain only path to correct location. It looks like git submodule init didn't create links to correct locations from these files.

Split tests into multiple files

Skip duplicate CI jobs

Wrong processing of messages split into multiple buffers

Hey!

As far as I can see, python4yahdlc doesn't use a continuous buffer, like yahdlc recommends, but still persists its state. This makes it dump raw memory sometimes and doesn't allow for proper partial frames. You either need to store incoming data buffer somewhere and pull / discard bytes as they go (which would make it support partial frames), or call yahdlc_get_data_reset/yahdlc_get_data_reset_with_state after every call to yahdlc_get_data. (to just use yahdlc for HDLC frames parsing and just properly discard partial frames/buffers)

Best regards,
Piotr.