GithubHelp home page GithubHelp logo

Comments (4)

adamw avatar adamw commented on May 20, 2024

Yes, this is the correct behavior, RFC3986 doesn't require encoding / in the query, as the path is finished by the first occurence of ? (see seciton 3.4)

If you do want to add a parameter with / encoded, you can add a KeyValue(k, v, QueryFragmentEncoding.All) query fragment using the uri.queryFragment method. See https://github.com/softwaremill/sttp/blob/master/core/src/main/scala/com/softwaremill/sttp/Uri.scala#L136-L145 for the full logic

As for de-coding the java.net.URI, that's also correct, as all components are stored in the Uri instance in an un-encoded form, hence they are being URL-decoded when decomposing the java.net.URI.

from sttp.

hairylime avatar hairylime commented on May 20, 2024

thanks, that all makes sense.

The workaround you give almost works, except that the java URI encoder encodes spaces with +, and the (admittedly horrible) 3rd party api I'm trying to hit doesn't like those.

from sttp.

adamw avatar adamw commented on May 20, 2024

Hmm I don't think it's currently possible to encode space in query other than +. A possible work around would be to add QueryFragmentEncoding.None and then you could do:

uri"http://notahost.com".queryFragment(QueryFragment.KeyValue("query", "a%20b", valueEncoding = QueryFragmentEncoding.None))

what do you think?

from sttp.

adamw avatar adamw commented on May 20, 2024

Fixed in 2.0.0-M6: URI encoding is fully configurable

from sttp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.