spudd86 / glyphy Goto Github PK

High-DIP (i.e. Macbook Retina Pro) still draws at standard resolution.

Branch name: maysum2

Purpose of code changes on this branch:
Two jobs- display glyphs containing overlapping contours correctly, and enable 
anisotropic antialiasing.

When reviewing my code changes, please focus on:
Style and form of commits, as the code *should* still be correct and functional.

After the review, I'll merge this branch into:
/trunk

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

What steps will reproduce the problem?
1. build library
2. install library

What is the expected output? What do you see instead?

i expect to see libglyphy-0.1 in /usr/local/lib/ but I see 
/usr/local/lib/libglyphy.0.dylib instead.

$ pkg-config --cflags --libs glyphy
-I@glyphy_includedir@ -L/usr/local/lib -lglyphy-0.1


What version of the product are you using? On what operating system?
the ambiguous version is the problem :)
compiling on: OSX Mavericks
Darwin 13.0.0 Darwin Kernel Version 13.0.0: Thu Sep 19 22:22:27 PDT 2013; 
root:xnu-2422.1.72~6/RELEASE_X86_64 x86_64


Please provide any additional information below.

// file: glyphy.pc.in:10
Libs: -L${libdir} -lglyphy-0.1

// file: configure.ac:27
GLYPHY_LIBTOOL_VERSION_INFO="0:0:0"

// file: Makefile.in:139
libglyphy_la_LINK = $(LIBTOOL) $(AM_V_lt) --tag=CXX $(AM_LIBTOOLFLAGS) \
    $(LIBTOOLFLAGS) --mode=link $(CXXLD) $(AM_CXXFLAGS) \
    $(CXXFLAGS) $(libglyphy_la_LDFLAGS) $(LDFLAGS) -o $@

Currently glyphy-demo allows the user to pass a text string to be rendered as 
also select the font to be used, but it could do it in a more robust way (i.e. 
calling ./glyphy-demo -h will crash the app).

The attached patch fixes it using getopt(), by allowing the user to pass the 
parameter using flags (e.g. 
./glyphy-demo -t "test test" -f /Library/Fonts/Microsoft/Calisto\ MT). 

It will also properly handle cases where you can may want to just change the 
font (while using the default text string) or the other way around.

Hi.Should this lib compile on Windows?I am trying to install it but I have 
multiple conflicts with windows C/c++ libraries.

Thanks.

The demo doesn't compile on MacOS X with case-sensitive filesystems because the 
glut.h include has wrong case.

Here is patch.

Thanks for this project! 

But further documentation of glyphy is reqired to really unterstand the code.

1. What is the diffrent between the branches: mster, maysum, maysum2 ?
2. What do the diffrent shaders?
3. Some screenshots would be nice to get a picture of quality   improvements!

What steps will reproduce the problem?
1. $ ./autogen.sh
2. $ make && make install
3. $ pkg-config --clags glyphy

What is the expected output? What do you see instead?
I expect to see a posix path like `/usr/local/include/glyphy` but instead see a 
make variable that has failed to be replaced

What version of the product are you using? On what operating system?
sha: 0dd6d4

OSX Mavericks
Darwin 13.0.0 Darwin Kernel Version 13.0.0: Thu Sep 19 22:22:27 PDT 2013; 
root:xnu-2422.1.72~6/RELEASE_X86_64 x86_64

Please provide any additional information below.

// file: glyphy.pc.in:12
Cflags: -I@glyphy_includedir@

What steps will reproduce the problem?
1. make a main.cpp with extern "C" { #include <glyphy-freetype.h> }
2. build main.cpp with clang

What is the expected output? What do you see instead?

clang reports a number of warnings, all implicit type narrowing errors:

In file included from ../src/main.cpp:14:
/usr/local/include/glyphy/glyphy-freetype.h:43:24: error: 
non-constant-expression cannot be narrowed from type 'FT_Pos' (aka 'long') to 
'double' in initializer list [-Wc++11-narrowing]
  glyphy_point_t p1 = {to->x, to->y};

I expect there to be no casting errors.

What version of the product are you using? On what operating system?

// $ uname -a 
Darwin 13.0.0 Darwin Kernel Version 13.0.0: Thu Sep 19 22:22:27 PDT 2013; 
root:xnu-2422.1.72~6/RELEASE_X86_64 x86_64

// file: config.h
#define PACKAGE_STRING "glyphy 0.2.0"

// $ clang++ -v
clang version 3.3 (tags/RELEASE_33/final)
Target: x86_64-apple-darwin13.0.0
Thread model: posix

Please provide any additional information below.

OS: Ubuntu 14.04

What steps will reproduce the problem?
1. ./glyphy-demo /usr/share/fonts/truetype/unfonts-core/UnBatang.ttf 뷁

What is the expected output? What do you see instead?
As attached file, there is artifact between ㅂ and ㅜ.

Add support to skip demo and its dependencies during 'configure' and to not 
build demo when running 'make'.