bug: legit steam id connected with already connected legit steam id about sm-ext-connect

[maxime1907]

mhh okay it happens if player looses the connection to the server and sv_timeout is high enough so that when client disconnect and reconnects it says that his connection is still alive on the server

How to reproduce

1. Connect to the server and wait to be in game
2. Remove the internet cable so that you are in retry mode with a red message at the top right corner
3. Disconnect from the server
4. Plug back your internet cable and reconnect -> Steam ID already in use

Links

• https://github.com/srcdslab/source-engine-2018-hl2_src/blob/0301dccccd5553587cba988daa0763081a1f409e/engine/baseserver.cpp#L1240
• https://github.com/srcdslab/source-engine-2018-hl2_src/blob/0301dccccd5553587cba988daa0763081a1f409e/engine/baseserver.cpp#L434
• https://github.com/srcdslab/source-engine-2018-hl2_src/blob/0301dccccd5553587cba988daa0763081a1f409e/tier1/NetAdr.cpp#L32
• https://git.botox.bz/CSSZombieEscape/sm-ext-connect/src/commit/c2aeb086e21ad26866857f10d13726e7015fa063/extension.cpp#L310
• https://github.com/srcdslab/source-engine-2018-hl2_src/blob/0301dccccd5553587cba988daa0763081a1f409e/engine/net_chan.cpp#L2847

Solution

Check if connected player has timed out and allow incoming player