bug: spoofer: steam id already in use on this server about sm-ext-connect

[maxime1907]

L 09/07/2023 - 23:04:51: [CONNECT]  SteamAuthFailed: 1 (1) | retVal = 1
L 09/07/2023 - 23:04:51: "spoofer<29><><>" connected, address ""
L 09/07/2023 - 23:04:51: "spoofer<29><><>" connected, address ""
Client "spoofer" connected ().
L 09/07/2023 - 23:04:51: [CONNECT]  SteamLegal: 0 (0)
L 09/07/2023 - 23:04:51: "toto <2><]><CT>" disconnected (reason "STEAM UserID is already in use on this server")
L 09/07/2023 - 23:04:51: [CONNECT]  SteamClientAuthenticated: 0
L 09/07/2023 - 23:04:51: [CONNECT]  SteamClientAuthenticated: 0
Dropped toto from server (STEAM UserID  is already in use on this server)

[maxime1907]

How to reproduce

1. I join in steamid valid
2. I change steamid - spoof
3. I type retry in the console - My connection is rejected a 1st time:

• Disconnect: Trying to join with a legitimate steamid while not authenticated with steam...

4. If I type retry in the console again:

• Disconnect: Trying to join with a legitimate steamid while not authenticated with steam...

5. If I connect by typing the password: Access to the server with a spoofed steamid ✅

Misc

Tested with ze elite steam id spoofer on css v92

[maxime1907]

my best guess is that it somehow replaces the storage:

• sm-ext-connect/extension.cpp

  Line 348 in 19ffadb

  ConnectClientStorage Storage(address, nProtocol, iChallenge, iClientChallenge, nAuthProtocol, pchName, pchPassword, pCookie, cbCookie);

[maxime1907]

Useful resources:

• https://github.com/srcdslab/source-engine-2018-hl2_src/blob/0301dccccd5553587cba988daa0763081a1f409e/engine/baseserver.cpp#L434
• https://github.com/perilouswithadollarsign/cstrike15_src/blob/f82112a2388b841d72cb62ca48ab1846dfcc11c8/engine/baseserver.cpp#L519
• https://git.botox.bz/CSSZombieEscape/sm-ext-connect
• https://wiki.alliedmods.net/Generic_Source_Server_Events#player_activate