Comments (13)
Aha, no, the problem at
https://github.com/dominictarr/patchbay/blob/master/modules/tabs.js#L84
Which assumes that any http link is external. Instead, we need to check if it's on a different domain,
and treat links to the same domain as local links. I'll fix this.
from patchbay.
confirmed fixed when deployed to ssb.evbogue.com
from patchbay.
hmm, how about a "reply" button that opens the thread in a lightbox? or takes you to the thread?
prehaps with the textarea focused. I'd like for it to show the whole thread somehow, because that incourages more considered replies.
from patchbay.
simple idea: ...why not
add a simple text of "... reply" next to the hour?
this way people would click it. I would
from patchbay.
Beyond the UX issue, I've discovered the actual issue here is threads do not work when you're running the lite client at a port and serving it up at a url. When you click a thread, it just opens patchbay in a new browser window.
Threads do work when you save the lite client to your desktop. This is also a faster experience because the browser isn't downloading 2mb of javascript every time you reload the page.
@benjajuarez are you using the lite client from ssb.evbogue.com or did you download the patchbay-latest html file from my site?
from patchbay.
from patchbay.
@evbogue do you have ssb-links and ssb-query installed?
from patchbay.
@dominictarr I didn't have them installed on my server. Installing ssb-links and ssb-query fixed the permalinks issue at http://ssb.evbogue.com/
from patchbay.
@evbogue aha, I see it. when you click re: link it opens it in a new tab.
I put this in https://github.com/dominictarr/patchbay/blob/master/modules/tabs.js#L79-L80
and it stopped doing this (weird thing is that it only happens when use use http served html, but not when you open it as a file) the reply links must be being triggered via a different path...
from patchbay.
fixed in 1.7.6!
from patchbay.
oops, no i broke other stuff...
from patchbay.
okay fixed in 1.7.7
from patchbay.
I believe 1.7.7 and #41 resolve this issue.
from patchbay.
Related Issues (20)
- Empty window with “electron” version 5.0.6 HOT 2
- some posts are not shown on discussion pages HOT 1
- Difficulties in doing npm install HOT 3
- Migrate from Gossip to CONN HOT 3
- Chess boards and pieces not displayed (v8.1.0) HOT 2
- Patchbay corrupts .ssb/config file HOT 1
- Styling is a bit weird, text hard to read HOT 6
- Cannot compile patchbay HOT 8
- Contribute link in README 404s HOT 3
- Patchbay Window Doesn't Appear When Switching Identities HOT 2
- /books doesn't show any books HOT 8
- Enhancement: Responsive UI while creating indexes HOT 8
- Create a new release HOT 1
- Is project being maintained? HOT 5
- TypeError: Cannot read property 'id' of null
- MacOS npm install failure
- Cannot Connect With Local Peers
- Blank screen... HOT 1
- Is this project dead? HOT 2
- Patchbay broadcasts to the whole internet instead of the local network
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from patchbay.