GithubHelp home page GithubHelp logo

Make replying more intuitive about patchbay HOT 13 CLOSED

ssbc avatar ssbc commented on May 16, 2024
Make replying more intuitive

from patchbay.

Comments (13)

dominictarr avatar dominictarr commented on May 16, 2024 1

Aha, no, the problem at
https://github.com/dominictarr/patchbay/blob/master/modules/tabs.js#L84

Which assumes that any http link is external. Instead, we need to check if it's on a different domain,
and treat links to the same domain as local links. I'll fix this.

from patchbay.

evbogue avatar evbogue commented on May 16, 2024 1

confirmed fixed when deployed to ssb.evbogue.com

from patchbay.

dominictarr avatar dominictarr commented on May 16, 2024

hmm, how about a "reply" button that opens the thread in a lightbox? or takes you to the thread?
prehaps with the textarea focused. I'd like for it to show the whole thread somehow, because that incourages more considered replies.

from patchbay.

benjajuarez avatar benjajuarez commented on May 16, 2024

simple idea: ...why not
add a simple text of "... reply" next to the hour?

this way people would click it. I would

from patchbay.

evbogue avatar evbogue commented on May 16, 2024

Beyond the UX issue, I've discovered the actual issue here is threads do not work when you're running the lite client at a port and serving it up at a url. When you click a thread, it just opens patchbay in a new browser window.

Threads do work when you save the lite client to your desktop. This is also a faster experience because the browser isn't downloading 2mb of javascript every time you reload the page.

@benjajuarez are you using the lite client from ssb.evbogue.com or did you download the patchbay-latest html file from my site?

from patchbay.

benjajuarez avatar benjajuarez commented on May 16, 2024
  1. not in browser at ssb
  2. yes, I downloaded the patchbay-latest html file from your site

from patchbay.

dominictarr avatar dominictarr commented on May 16, 2024

@evbogue do you have ssb-links and ssb-query installed?

from patchbay.

evbogue avatar evbogue commented on May 16, 2024

@dominictarr I didn't have them installed on my server. Installing ssb-links and ssb-query fixed the permalinks issue at http://ssb.evbogue.com/

from patchbay.

dominictarr avatar dominictarr commented on May 16, 2024

@evbogue aha, I see it. when you click re: link it opens it in a new tab.
I put this in https://github.com/dominictarr/patchbay/blob/master/modules/tabs.js#L79-L80
and it stopped doing this (weird thing is that it only happens when use use http served html, but not when you open it as a file) the reply links must be being triggered via a different path...

from patchbay.

dominictarr avatar dominictarr commented on May 16, 2024

fixed in 1.7.6!

from patchbay.

dominictarr avatar dominictarr commented on May 16, 2024

oops, no i broke other stuff...

from patchbay.

dominictarr avatar dominictarr commented on May 16, 2024

okay fixed in 1.7.7

from patchbay.

evbogue avatar evbogue commented on May 16, 2024

I believe 1.7.7 and #41 resolve this issue.

from patchbay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.