supercharge / redis-github-action Goto Github PK

I got an error,
ERR Client sent AUTH, but no password is set
So how to set the Redis password?

Related to #3 where the Docker command leads to an invalid format because of the missing Redis version.

Tasks

• validate the incoming Redis version before trying to start a Docker container
• Log a useful error message when validation fails

Make this action available to windows-latest image. Currently only runs on linux or macOS images

Currently I add redis-tools myself, so my action.yml looks like this. I think it will be helpful if redis-cli is included in your action

...
- name: Start Redis
  uses: supercharge/[email protected]
  with:
    redis-version: ${{ matrix.redis-version }}

- name: Install redis cli
  run: sudo apt-get install -y redis-tools

Should it be possible to launch an alternative Redis package like Redis Stack by specifying a custom image name? 🤔

Potential implementation: #10

Hi,

Would you open to add an --rm option to the docker run to remove the container?
https://github.com/supercharge/redis-github-action/blob/main/start-redis.sh#L15

This will help with project that are running on shared self-hosted runner.

Two ways to do this:

1. Set --rm as the default at the docker run arg
2. Create a new optional args to pass in this option at the action level

Let me know your thought and I'm happy to send in PR.

Redis now has the old RESP 2 and the new RESP 3.

The docs don't seem to show how to pass a custom redis.conf file when starting the server. Is it possible?

Hello I'm Cho
First of all, thanks to you, I am able to conduct a virtual test using redis.
Currently I am using redis version 6 in my server.
But your usage seems to only support versions 4 and 5, can I use 6?

Thanks.
Cho

You mention 1.7 in the docs and the changelog, but I don't see an actual tag or release for it.

Hy @marcuspoehls

I'm currently trying to run a test redis server for my nodeJs app.
Sadly the actions throws the following error:
Failed to download action 'https://api.github.com/repos/superchargejs/redis-github-action/tarball/v1'. Error Response status code does not indicate success: 404 (Not Found).

After some tries the action fails.

I'm using:
nodeJs: 13.x
redis: 5

but it failed for all versions for me.

Greetings from Munich

Aaron

Would it be possible to have a basic 2-3 servers Redis cluster? 🤔

See https://github.com/Vectorface/cache/pull/8/checks?check_run_id=1592485519

/usr/bin/docker run --name cc4956c4ab57414d304381943ac46fbbdd502f_656d49 --label cc4956 --workdir /github/workspace --rm -e INPUT_REDIS-VERSION -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/cache/cache":"/github/workspace" cc4956:c4ab57414d304381943ac46fbbdd502f  ""
docker: invalid reference format.

Any thoughts? 🤔