talk-to / chocolate Goto Github PK

I'm not sure what are the cases that are not covered by the following simpler check:

BOOL TDTIsRunningUnderDebugger() {
  return isatty(STDERR_FILENO);
}

Also, [[NSProcessInfo processInfo] tdt_isBeingDebugged] requires private API and will need to be turned off in Release builds, with the result that we cannot run the debugger on Release builds (not a deal breaker, but if there is not much of a difference, then the isatty check seems simpler and also works on Release builds).

Alternatives:

• stringAfterNillingBlank
• stringAfterNillingEmpty
• Keep the current name but change semantics to remove all blanks.

Since any of these will be a breaking change, consider doing this around the next major release.

See https://github.com/directi/iTalkto/pull/1213

https://github.com/talk-to/Gordon/blob/b4a66ddb3994606815092ab9ffc48702a2a540ff/GCurl/GCurl/NSPrintf.h

This is a note to myself.

NSDateFormatter is not thread safe. That is why you will notice that TDTLog uses it in a synchronized block. It won't be so obvious to someone else using it -- its best if TDTLog uses a private instance of an ISO8601 formatter.

https://github.com/talk-to/Chocolate/blob/master/TDTChocolate/FoundationAdditions/NSMutableArray+TDTQueueing.h#L9

This is what I get:

dyld: Symbol not found: _CFAutorelease
  Referenced from: /Users/chaitanya/Library/Developer/Xcode/DerivedData/TDTChocolate-bepfamhlsfblaxelmhzxcaygqngl/Build/Products/Debug/OSXTests.xctest/Contents/MacOS/OSXTests
  Expected in: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation

It looks like we aren't linking Foundation/Core Foundation to the project.

https://github.com/talk-to/Gordon/blob/b4a66ddb3994606815092ab9ffc48702a2a540ff/GCurl/GCurl/NSNotificationCenter%2BTDTObserverAdditions.h

Note to self.

@chaitanyagupta @shilp-gupta Could both of register with the "pod trunk" service and let me know of your registered emails (doesn't have to be your GH email - I used my @talk.to one) so that I can add you as owners of the Chocolate pod.

Here's an example command for registration:

$ pod trunk register [email protected] 'Orta Therox' --description='macbook air'

Reference