GithubHelp home page GithubHelp logo

chocolate's Issues

Why do we require [[NSProcessInfo processInfo] tdt_isBeingDebugged]?

I'm not sure what are the cases that are not covered by the following simpler check:

BOOL TDTIsRunningUnderDebugger() {
  return isatty(STDERR_FILENO);
}

Also, [[NSProcessInfo processInfo] tdt_isBeingDebugged] requires private API and will need to be turned off in Release builds, with the result that we cannot run the debugger on Release builds (not a deal breaker, but if there is not much of a difference, then the isatty check seems simpler and also works on Release builds).

Consider renaming tdt_stringAfterNillingBlanks

Alternatives:

  • stringAfterNillingBlank
  • stringAfterNillingEmpty
  • Keep the current name but change semantics to remove all blanks.

Since any of these will be a breaking change, consider doing this around the next major release.

Can't run tests on OS X

This is what I get:

dyld: Symbol not found: _CFAutorelease
  Referenced from: /Users/chaitanya/Library/Developer/Xcode/DerivedData/TDTChocolate-bepfamhlsfblaxelmhzxcaygqngl/Build/Products/Debug/OSXTests.xctest/Contents/MacOS/OSXTests
  Expected in: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation

It looks like we aren't linking Foundation/Core Foundation to the project.

+[NSDateFormatter sharedISO8601Formatter] is not safe

NSDateFormatter is not thread safe. That is why you will notice that TDTLog uses it in a synchronized block. It won't be so obvious to someone else using it -- its best if TDTLog uses a private instance of an ISO8601 formatter.

Spread the ownership

@chaitanyagupta @shilp-gupta Could both of register with the "pod trunk" service and let me know of your registered emails (doesn't have to be your GH email - I used my @talk.to one) so that I can add you as owners of the Chocolate pod.

Here's an example command for registration:

$ pod trunk register [email protected] 'Orta Therox' --description='macbook air'

Reference

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.