teliadk / terraform-aws-microservice Goto Github PK

Right now, the module creates one ingress rule and one egress rule which is static and should be set from outside the module instead.

We could either let this be up to the consumer of the module by simply exposing the security group id and have them setup the security group rules through terraform security_group_rule or by using the dynamic feature of HCL >=0.12 to dynamicly create these based on user input.

NOTE: Public Repos are disabled for this organization! Repository was automatically converted to a Private Repo. Please contact an admin to override.

/cc @joakimhew
/cc @casperc

Unfortunately it is not possible to use both implicitly defined ingress/egress rules and explicitly defined rules using the aws_security_group_rule in terraform as this creates a conflict and causes some rules to disappear. To solve this we should remove the implicitly defined rules and only define ingress/egress explicitly with aws_security_group_rule.

More information about this is found on the top of the documentation for aws_security_group_rule

NOTE on Security Groups and Security Group Rules: Terraform currently provides both a standalone Security Group Rule resource (a single ingress or egress rule), and a Security Group resource with ingress and egress rules defined in-line. At this time you cannot use a Security Group with in-line rules in conjunction with any Security Group Rule resources. Doing so will cause a conflict of rule settings and will overwrite rules.

The following locals should be variables instead.

When creating the microservice module resources, we should check if a task definition already exist and use the image from there to prevent updating to the latest image whenever infrastructure changes