thasmo / external-svg-polyfill Goto Github PK

Consider triggering events for certain actions.

• SVG inserted
• SVG removed
• SVG href changed
• etc.

The element cache can't handle multiple SVG use elements with the same URL at the moment. This becomes a problem when running destroy, which does not restore all elements.

Seems to be used by webpack but doesn't export any modules, which kinda breaks builds and is not the intended outcome.

After upgrading from Webpack Encore 0.33 to 1.7.0 I have the following error:

> encore production
Running webpack ...
 WARN  Compiled with 1 warnings7:47:55 AM
 warn  in ./packages/theme/Resources/Private/Js/main.js7:47:55 AM
export 'default' (imported as 'ExternalSvgPolyfill') was not found in '@thasmo/external-svg-polyfill' (module has no exports)
 ERROR  Failed to compile with 1 errors7:47:55 AM
Module build failed: Module not found:
"./node_modules/@thasmo/external-svg-polyfill/module/index.js" contains a reference to the file "./core/Polyfill".
This file can not be found, please check it for typos or update it if the file got moved.
Entrypoint main = runtime.f831b087.js 189.1818b934.js 800.6b815a86.js main.7c7f9bd6.css main.bb64df66.js 73 auxiliary assets
webpack compiled with 1 error and 1 warning

The main difference is, that Webpack Encore 1.x uses Webpack 5 instead of Webpack 4.

workaround

When I change the import from

export { default } from './core/Polyfill';

to

export { default } from './core/Polyfill.js';

it works fine.

Also: when I remove "type": "module", from your npm-package's package.json - it compiles fine too.

I know that in Webpack 5 something changed about Node modules loading. But I thought that referes only to old "require" statements and default Node.js modules like "path" and so on.