Comments (8)
talentlessguy
commented on May 14, 2024
2
@ahmad-reza619 yeah must work the same
code might differ
from tinyhttp.
talentlessguy
commented on May 14, 2024
1
implemented in 2bba94c, but not 1:1 to express
need more time to make it have the same API
from tinyhttp.
ahmad-reza619
commented on May 14, 2024
Hi @talentlessguy i would like to take this on, is the shape of sendFile function has to be just like express?
from tinyhttp.
talentlessguy
commented on May 14, 2024
@ahmad-reza619 also, if possible, it shouldn't introduce any new dependencies
from tinyhttp.
ahmad-reza619
commented on May 14, 2024
is this sendFile function will be able to send any kind of file? like maybe mp3 file?
from tinyhttp.
ahmad-reza619
commented on May 14, 2024
From what i see from express test case, it looked like it only send file with text inside it
from tinyhttp.
talentlessguy
commented on May 14, 2024
@ahmad-reza619 hmmm I think u're right but I by myself can't undertsand whether it sends a file with Content-Disposition header to download it, or just raw file
need to investiage more and re-check the implementation
from tinyhttp.
talentlessguy
commented on May 14, 2024
I think it's implemented properly, if anyone has suggestions, feel free to write here and I will re-open the thread
from tinyhttp.
Related Issues (20)
- Response object interface doesn't match @types/express behavior, it's not really generic HOT 6
- Simple Pull Request - License-none
- Failed to start https server HOT 1
- Multiple path arguments (as array) to route HOT 4
- Link CONTRIBUTING.md in README.md and mention forking as the first step instead of clone HOT 1
- Incompatible with Express middleware: `express.Handler` HOT 26
- Mounting a subapp on array of paths
- Add missing `accepts` TypeScript signatures HOT 4
- Mallformed URI's leads to crash with `/thing/:id` routes HOT 1
- app.use(<path>, <Router>) is Incompatible with Express HOT 8
- Exporting a router file is not working HOT 7
- Create a community server HOT 8
- The website is down HOT 7
- Request `.xhr` misses fetch requests (headers are lowercase) HOT 3
- req.route always returns undefined HOT 19
- Server instance (of `@tinyhttp/app`) hangs on test since 2.0.33 HOT 4
- Predefined error type HOT 4
- ZOD support / example HOT 6
- Wildcards strip the first character from `req.url` HOT 10
- [docs] outdated app.engine example with eta HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tinyhttp.