Comments (5)
I agree adding a js
feature that maps to getrandom/js
is best.
I used to manually set getrandom/js
whenever I see wasm-bindgen
so ahash
works properly but then the new version now has no way to turn it off.
from ahash.
This also causes #141 which breaks no-std
builds.
from ahash.
In fact, the standard ahash
with default-features = false
will ALWAYS bring in wasm-bindgen
(you can tell by inspecting Cargo.lock
) for ANY TARGET and all its dependencies for no apparent reason, all because getrandom/js
is turned on.
That is because cargo
seems to merge the features regardless of whether they only showed up in specific target sections. Once it shows up in one target, it shows up in all targets.
[target."cfg(not(any(target_arch = \"wasm32\", target_abi = \"unknown\")))".dependencies.getrandom]
does not appear to prevent the js
feature from being added to getrandom
(not to mention target_abi
does not seem to be stabilized yet) even when the target is not wasm32
.
Therefore, there is no way to "turn off" getrandom/js
, which breaks no-std
in a major way.
from ahash.
rust-lang/cargo#4866 and rust-lang/cargo#1197 document the fact that target-specific features are not supported. All features are merged regardless of target.
Supposedly resolver = "2"
will resolve (pun intended) this target-specific features issue, but in my tests this is not the case, as confirmed by the GitHub issues. resolver = "2"
doesn't prevent features set on targets not built to be merged.
from ahash.
Fixed
from ahash.
Related Issues (20)
- test failure on s390x. HOT 1
- Significant performance regression from 0.8.6 to 0.8.7 HOT 11
- compile error: use of unstable library feature 'stdsimd' HOT 20
- feature request: ahash without length prefixing HOT 3
- Deterministic hash value HOT 2
- error[E0635]: unknown feature `stdsimd` HOT 19
- Significant bump in MSRV from 0.8.7 to 0.8.8 HOT 9
- No link to crates.io HOT 1
- RandomState has too many collisions in low order bits when hashing a u64 HOT 29
- Hashing `&T` yields different results compared to `T`
- Fragile build script: crate automatically enables "specialize" feature HOT 14
- ahash 0.8.11 breaks hashbrown? HOT 6
- Work around `swap_bytes` on WebAssembly HOT 1
- git source unaligned with crates.io release HOT 5
- Linking Errors with Specific Optimization Levels When Running Test Cases HOT 1
- rust v1.78 std simd feature removed HOT 1
- `set_random_source` never returns `Err(false)`
- Replace atomic-polyfill with portable-atomic
- Mismatch between published version on crates.io and tagged version in git repo for v0.8.11 HOT 8
- Suggestion: Alternative wrapper HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ahash.