GithubHelp home page GithubHelp logo

Comments (3)

tkonopka avatar tkonopka commented on May 10, 2024

Thanks for the bug report and the detailed examples. Can confirm that I can reproduce the effect. WIll investigate.

from umap.

tkonopka avatar tkonopka commented on May 10, 2024

Thanks again for spotting this bug. I just committed an update; it fixes the issue as far as I can tell. Would you be able to try it out too? Many thanks.

Here's more background. min_dist is used together with spread to tune how close together items should appear in the final embedding. An alternative way to achieve the same tuning is via parameters a and b. The latter pair actually take precedence. By default, a and b are None in umap-learn, so changing min_dist (and/or spread) is an effective way of altering the embedding. But if a and b are set, values assigned to min_dist or spread become irrelevant.

The bug in the R package arose because NAs for a and b in the configuration object were mistakenly translated into python number-like values. Those number-like values for a and b made min_dist inactive; calculations with different min_dist produced equivalent coordinates. The fix avoids sending NA values to umap-learn, thus avoids setting a and b, and thus enables min_dist to take effect.

from umap.

lgaborini avatar lgaborini commented on May 10, 2024

Looking great also in my code! Thank you!

from umap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.