treeform / flippy Goto Github PK

View Code? Open in Web Editor NEW

60.0 5.0 9.0 21.53 MB

Flippy is a simple 2d image and drawing library.

License: MIT License

Nim 98.94% HTML 1.06%

flippy's Issues

Resizing Images using -d:useStl giving strange results

I have a test image:

as you can see, it's roughly 10mb big and has a resolution 10315y7049

if i run the following code, it results in that image:

     var image = loadImage(file)
      if image.width > maxWidth or image.height > maxHeight:
        var height = cast[float64](image.height)
        var width = cast[float64](image.width)
        var finalHeight, finalWidth: int
        #echo "Resolution old ", image.height, "x", image.width
        var vh = cast[float64](height / width)
        #echo "VH: ", vh
        if height >= width:
          finalHeight = cast[int](maxHeight)
          finalWidth = cast[int](width / vh)
        else:
          finalWidth = cast[int](maxWidth)
          finalHeight = cast[int](height * vh)
        #echo "Resolution:", image.height, "x", image.width, "-->", finalHeight, "x", finalWidth
        image.height = finalHeight
        image.width = finalWidth  
        image.save(file)

The resulting image has a size of 40MB and looks like this:

image.putRgba issue or user error ?

Hi,

Trying this simple test does not seem to work on OSX, Am I using it wrong 🙈 ?

import flippy, chroma

const w = 128
const h = 128

proc flipTest*() = 
  var image = newImage(w,h,4)
  for x in {0..w-1}:
    for y in {0..h-1}:
      if x < int(w/2):
        image.putRgba(x, y, rgba(255, 0, 0, 255))
      else:
        image.putRgba(x, y, rgba(0, 0, 255, 255))
  image.save("test.png")

Error: undeclared identifier: 'Rect'

Thanks for this great library!

This error is on Linux (docker nim-lang/nim:1.4.2). The same code seems to work fine on macOS

# cat foo.nim 
import os
import flippy

proc resizePNG*(src:string, dst:string, width:int, height:int) =
  loadImage(src).resize(width, height).save(dst)

when isMainModule:
  resizePNG(paramStr(1), paramStr(2), 100, 100)

# nim c foo.nim 
Hint: used config file '/nim/config/nim.cfg' [Conf]
Hint: used config file '/nim/config/config.nims' [Conf]
........................................
/root/.nimble/pkgs/flippy-0.4.7/flippy.nim(311, 42) Error: undeclared identifier: 'Rect'

# nimble list -i
chroma  [0.1.5]
flippy  [0.4.7]
nimPNG  [0.3.1]
supersnappy  [2.0.0]
vmath  [0.4.0]

# nim --version
Nim Compiler Version 1.4.2 [Linux: amd64]
Compiled at 2020-11-30
Copyright (c) 2006-2020 by Andreas Rumpf

git hash: 3fb5157ab1b666a5a5c34efde0f357a82d433d04
active boot switches: -d:release -d:danger

# uname -a
Linux 883414a58802 5.4.39-linuxkit #1 SMP Fri May 8 23:03:06 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Float precision ?

Thanks for flippy I have been using it on a few projects lately.
I was wondering if there is a plan to add float precision images?

Thanks

Can pictures be saved as memory files?

Can pictures be saved as memory files? I don't want to generate on disk because I generated temporary files

STBI Exception

When trying to use fllippy to minify an image I keep getting an error on

loadImage
stb_image\read.nim(91) load
Error: unhandled exception: can't fopen [STBI Exception]

How did I call?
var a = reduceImage("C:\\Nim\\NimExamples\\MyRecipes\\a.png", "C:\\Nim\\NimExamples\\MyRecipes\\b.png", 3)
against proc

proc reduceImage*(inFile: string, outFile: string, scale: cint): cint {.cdecl, exportc, dynlib.} =
  ## reduces image
  var image = loadImage(inFile)
  image = image.minify(scale)
  image.save(outFile)
  result = scale

Is it my own stupidity, or is it a real issue? I am on windows as you probably guessed.

does not support Unicode filenames on Windows

can't fopen exception when loading or saving an image with Unicode characters in the path on Windows

stb_image C library itself supports Unicode filenames on Windows:
nothings/stb#557

Loops in flippy access memory discontinuously

In procs in src/flippy.nim, most loop change y coordinate in inner loop and change x coordinate in outer loop.
That means these loops access memory discontinuously.
I think inner loop and outer loop in src/flippy.nim should be swapped for continuous memory access and better performance.

I swapped inner loop and outer loop of flippy.blit and measured time.

test.nim:

import flippy, times, vmath, chroma

template measure(body: untyped) =
  let before = epochTime()
  body
  let after = epochTime()

  echo after - before, "sec"
 
#changed inner loop and outer loop of flippy.blit for continuous memory access
proc blit2(destImage: Image, srcImage: Image, pos: Vec2) =
  for y in 0..<int(srcImage.height):
    for x in 0..<int(srcImage.width):
      var rgba = srcImage.getRgba(x, y)
      destImage.putRgbaSafe(int(pos.x) + x, int(pos.y) + y, rgba)

proc main =
  const
    width = 4000
    height = 4000

  var
    src = newImage(width, height, 4)
    dst = newImage(width, height, 4)

  for y in 0..<height:
    for x in 0..<width:
      let v = uint8((x xor y) and 0xff)
      src.putRgba(x, y, ColorRGBA(r: v, g: v, b: v, a: 255))

  measure:
    blit(dst, src, vec2(0.0, 0.0))
    #blit2(dst, src, vec2(0.0, 0.0))

  dst.save("test.png")

main()

I compiled it with following command:

nim c -r -d:danger test.nim

When I measured flippy.blit, time was about 0.42 seconds.
When I measured blit2, time was about 0.083 seconds.

>nim -v
Nim Compiler Version 1.2.6 [Windows: amd64]
Compiled at 2020-07-29
Copyright (c) 2006-2020 by Andreas Rumpf

git hash: bf320ed172f74f60fd274338e82bdc9ce3520dd9
active boot switches: -d:release

Unnecessary param in computeBounds

https://github.com/treeform/flippy/blob/master/src/flippy.nim#L436

Looks like matInv was never used in that proc.

Incorrect color after minifying image

var img = newImage(500, 500, 4)

img.fill(rgba(255, 255, 255, 255))
img = img.minify(2)

img.save("out.png")

In the PNG file exported above, the background color is #FCFCFC (252, 252, 252).

flippy.nim(1, 22) Error: cannot open file: chroma/blends

When I run nimble test with the latest version I get this error:

$ nimble test
  Verifying dependencies for [email protected]
      Info: Dependency on vmath@>= 0.3.2 already satisfied
  Verifying dependencies for [email protected]
 Installing chroma@>= 0.1.5
Downloading https://github.com/treeform/chroma using git
  Verifying dependencies for [email protected]
 Installing [email protected]
   Success: chroma installed successfully.
      Info: Dependency on nimPNG@>= 0.2.6 already satisfied
  Verifying dependencies for [email protected]
      Info: Dependency on supersnappy@>= 1.0.0 already satisfied
  Verifying dependencies for [email protected]
      Info: Dependency on bumpy@>= 0.2.1 already satisfied
  Verifying dependencies for [email protected]
      Info: Dependency on vmath@>= 0.4.0 already satisfied
  Verifying dependencies for [email protected]
  Compiling /Users/matt/lib/flippy/tests/test (from package flippy) using c backend
/Users/matt/lib/flippy/src/flippy.nim(1, 22) Error: cannot open file: chroma/blends
       Tip: 26 messages have been suppressed, use --verbose to show them.
     Error: Execution failed with exit code 256
        ... Command: /Users/matt/.nimble/bin/nim c --noNimblePath -d:NimblePkgVersion=0.4.7 --path:/Users/matt/.nimble/pkgs/vmath-0.4.0 --path:/Users/matt/.nimble/pkgs/chroma-0.2.1 --path:/Users/matt/.nimble/pkgs/nimPNG-0.3.1 --path:/Users/matt/.nimble/pkgs/supersnappy-2.0.0 --path:/Users/matt/.nimble/pkgs/bumpy-0.2.1 --path:/Users/matt/.nimble/pkgs/vmath-0.4.0 --hints:off -r --path:. /Users/matt/lib/flippy/tests/test

Artifacts introduced when rendering subpixels

When any element lands on a subpixel (any non-integer or non-.0 float), rendering artifacts will be introduced.

Tested on both size, position, and corner radius (in Fidget).

Flippy is not loading an image

When trying to load an image into flippy i'm getting illegal storage access errors and a signature mismatch error as well
Error seems to originate at line 106 where it is assigning the image width from png.width to result.width

flippy version: 0.4.5
os: OSX

the code to load in an image: var mainImage: Image = loadImage(imagepath)
Full error below

signature mismatch
Traceback (most recent call last)
/Users/__/Projects/Code/imgToGif/src/splitTga.nim(58) splitTga
/Users/__/Projects/Code/imgToGif/src/splitTga.nim(8) splitTgaToPng
/Users/__/.nimble/pkgs/flippy-0.4.5/flippy.nim(106) loadImage
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

The 'image.save()' method can only be saved on a local disk. Can it be saved in memory?

What I mean is that I generate a Picture, which is not stored on the local disk, but stored in memory, and then returned to the Web for display by the Web client. The existing 'image.save()' method can only be saved on a local disk.

Originally posted by @lihf8515 in #28 (comment)

Getting an error when running the basic usage example: Error: undeclared identifier: 'rgba'

Hi, thank you for writing this library. I tried compiling the basic example:

import flippy
# load an image
var image = loadImage("tests/lenna.png")
# print it out
echo image
# get a color pixel
echo image.getRgba(100, 100)
# put a color pixel
image.putRgba(10, 10, rgba(255, 0, 0, 255))
# blit a rectangular part from one place to another
blit(image, image, rect(0, 0, 100, 100), rect(100, 100, 100, 100))
# draw a line
image.line(vec2(11, 11), vec2(100, 100), rgba(0, 0, 0, 255))
# minify image by 2 or 1/2 or scale by 50%
image = image.minify(2)
# save the image to a file
image.save("tests/lenna2.png")

I use nim c flippy_test.nim and this is the output:

Hint: used config file '/Users/owner/.choosenim/toolchains/nim-1.4.0/config/nim.cfg' [Conf]
Hint: used config file '/Users/owner/.choosenim/toolchains/nim-1.4.0/config/config.nims' [Conf]
......................................
/Users/owner/nim/flippy/flippy_test.nim(9, 23) Error: undeclared identifier: 'rgba'

My OS is macOS Catalina Version 10.15.6. I'm using Nim Compiler Version 1.4.0 [MacOSX: amd64].

I'm new to Nim, so perhaps I'm missing something pretty obvious... (having to do with the wrappers for the C image libraries being used or something like that? Really don't know. 😅) Also, it compiles if I take out the lines that use rgba, vec2, and rect parameters.

Unable to build/install other libraries (e.g. NSU) that depends on flippy

There's an issue when trying to install other libraries such as Senketsu/nsu which depends on flippy. According to the error, it seems the issue lies with flippy.nim having an undeclared identifier "Rect". I also tried the latest version of flippy and it produced the same error.

The error I am getting is
/root/.nimble/pkgs/flippy-0.4.0/flippy.nim(206, 58) Error: undeclared identifier: 'Rect'
Tip: 16 messages have been suppressed, use --verbose to show them.
Error: Build failed for package: nsu
... Execution failed with exit code 1
... Command: /home/user/Desktop/nim-1.4.8/bin/nim c --colors:on --noNimblePath -d:release -d:NimblePkgVersion=0.1.5 --path:/root/.nimble/pkgs/x11-1.1 --path:/root/.nimble/pkgs/winim-3.6.1 --path:/root/.nimble/pkgs/flippy-0.4.0 --path:/root/.nimble/pkgs/vmath-1.0.8 --path:/root/.nimble/pkgs/chroma-0.2.5 --path:/root/.nimble/pkgs/print-1.0.0 --path:/root/.nimble/pkgs/stb_image-2.5 --hints:off -o:/home/user/Desktop/nsu/nsu /home/user/Desktop/nsu/src/nsu.nim

treeform / flippy Goto Github PK

flippy's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs