tylerreisinger / cache-macro Goto Github PK

A common use case for cacheing would be when making network calls to external services. In this case, a user might want to use a backing cache which supports a time to live for entries to ensure the data doesn't get stale.

I've created an expiring_map crate which could provide the backing data storage for this, but supporting the expiring_map cache within the lru-cache-macro would require some modifications to this crate.

I'd be wiling to attempt making a PR to add the necessary changes, if this is something you are interested in. One larger issue, however, is that it may make sense to rename this repo/crate to something more general (perhaps simply cache-macro?). Let me know what you think.

Right now, we use the proc_macro::Diagnostic interface for reporting errors. Diagnostic is able to show exact code spans and generally output the most useful information, but it is unable to be used outside of nightly right now. The compile_error! macro offers much less information to be output on error, but supporting it would allow cache-macro to be usable on stable.

A feature called nightly could be added to opt-in to the better DIagnostic interface.

Mutable references can cause soundness issues if the argument value is modified by the function. They should be denied in get_args_and_types.

There is no fundamental reason to deny self as long as it follows the same requirements as any other argument. Implementing this would require extending get_args_and_types to output the correct identifiers in the SelfValue and SelfRef arms.