us-cbp / ngx-cbp-theme Goto Github PK

I'm getting a ton of "Cannot find module '@angular/core'" messages. Is it possible that this is caused by the library being built on a release candidate version? Tried cloning my-app and got similar errors.

cbp-theme v1.8.x onwards started putting gutter which need to be inherited

AOT broken for consuming applications.

In example my-app

ng build --aot  

failed with bunch of errors complaining about 'undefined' value in the imports.

Recent/Favorites Application names as menu items are children of mat-menu-item and not benefiting from overflow handlers.

e.g.

Something like below should work. Other option is ensure these contents are inside with icon.
See https://plnkr.co/edit/WLpgR3LVZNDq1MFBktaq?p=preview

.cbp-applications-link {
   overflow: inherit;
   text-overflow: inherit;
}

When header shrinks the menus should close.

Material Toggle Switches look way off when look at a form. We need a new simple toggle switch where we can customize the label.. The ON and OFF contents and that provides easier model changes while providing the same styling.

As shown below

marble-mustache released a few days ago containing md-select changes and angular upgrade to > 4.4.3. This is a breaking change.

Incorrect import @angular/material/core/typings/common-behaviors/tabindex' causing issues on downstream applications.

Module not found: Error: Can't resolve '@angular/material/core/typings/common-behaviors/tabindex' in 'C:\Users\yyy\projs\ief\ief-mobile\node_modules\ngx-cbp-theme'chunk {
inlineresolve '@angular/material/core/typings/common-behaviors/tabindex' in 'C:\Users\yy\projs\ief\ief-mobile\node_modules\ngx-cbp-theme'
} inline.bundle.js, inline.bundle.js.map  Parsed request is a module (inline) 5.83 kB 
[entry] [rendered]  using description file: C:\Users\yy\projs\ief\ief-mobile\node_modules\ngx-cbp-theme\package.json (relative path: .)

Do we need an accordion component, or would it be better to rely on the HTML5 details/summary tags? Polyfills exist for IE support. Seems like simplicity and accessibility, using the HTML5 tags would be preferable.

e2e tests are barely testing much. We need the following at the minimum:-

• e2e for Applications Menu
• e2e test for cbp-header - high level - responsiveness.

When you click on CBP Header the click action should be configurable.

As shown below

Make the text darker.

mat-button-toggle class global override.

Not able to do this:

import {CBPNotificationsService} from 'ngx-cbp-theme';

Applications Menu on cbp-header displays the current application.

This can be registered with the service at boot or module initialization.

Should some of the component features of the header be abstracted out so that users can include only the ones necessary? For instance, If I don't want the Feedback link, then I simply don't include it. Some like the following?

<cbp-header>
    <cbp-apps-menu></cbp-apps-menu>
    <cbp-feedback-link></cbp-feedback-link>
    <cbp-user-menu></cbp-user-menu>
</cbp-header>

The header itself would only provide the branding and the toggle button.

Has any thought been given to using bootstrap as the base vs material? Essentially, instead of using material2, use ngx-bootstrap? While I think the material stuff is probably nicer, it seems like cbp-theme is a bootstrap theme with changes for material. By using Material as the base, it's hard to reuse much of the cbp-theme at all. You have to redo it to make it work for material. I wonder if we used bootsrap as the base, if we'd be able to use more of the base cbp-theme.

Once cbp-theme moved to a material theme, we could then make the same change, and hopefully again be able to reuse most of the cbp-theme. Thoughts?

isClosedInitially should default to false

options.isClosedInitially = options.isClosedInitially === true ? true : false;

Currently we copied the switch class as shown below.

We need to reuse it from cbp-theme which requires a PR for cbp-theme to extract that class out of forms.

Need to catch up to version 5 to avoid being behind and difficulty catching up.

Make header accessible.

Currently we expect user to click on Login on the Header however as a step towards getting SSO ready we need some provisions.

Need a service to display notifications as per systems notifications https://us-cbp.github.io/cbp-style-guide/docs/components/alerts.html

The service should be able to project a custom notification template into a notifications area.

Input is flushed on the left menu. The entire field can be inside a mat-menu-item with left/right margins.

Progress bar as below

Provide observable property in CBPApplicationsServices to get currentApp setting events rather than subscribing to the whole applicationsData.

Can cbp-header be changed from an md-toolbar to a simple header tag? Seems like it would be more semantic as well as accessible to use the standard html5 tag. Is md-toolbar providing some sort of functionality?

Both headers has few styles that are common.
We can extract this out into a single cbp-toolbar component.
If we do we should inherit from md-toolbar. See #8