GithubHelp home page GithubHelp logo

Comments (16)

SteveMacenski avatar SteveMacenski commented on June 8, 2024 11

Also support for ROS2 (I'm maintainer on ROS2 navigation2, would love to do testing with this!) would be great. I'd like to make formally supported integrations with this and ROS2 with navigation2 (https://github.com/ros-planning/navigation2).

I see a few ORB-SLAM2 references that weren't changed: https://github.com/UZ-SLAMLab/ORB_SLAM3/search?p=1&q=ORB_SLAM2&unscoped_q=ORB_SLAM2

Do you intend to support this and improve on it or is this a one-and-done research project? I ask because if we do some integrations with navigation2 we'll likely make improvements and want to know if we should fork this for the ROS world or submit PRs back here if there's support.

from orb_slam3.

Sunchanghao avatar Sunchanghao commented on June 8, 2024 7

just change ORBSLAM2::System into ORBSLAM3::System, I can compile the code by catkin_make

哈 那效果呢 是新版本的效果了吧 不知道会不会有什么问题

from orb_slam3.

xiefei2929 avatar xiefei2929 commented on June 8, 2024 5

I commited two visual-inertial ROS interfaces Mono_inertial and Stereo_inertial at https://github.com/xiefei2929/ORB_SLAM3-ROS-Interface

from orb_slam3.

liuzhenboo avatar liuzhenboo commented on June 8, 2024 3

ros代码里面的那些命名空间还是ORBSLAM2

from orb_slam3.

Sunchanghao avatar Sunchanghao commented on June 8, 2024 3

ros代码里面的那些命名空间还是ORBSLAM2

是啊 所以不知道啥意思

from orb_slam3.

liuzhenboo avatar liuzhenboo commented on June 8, 2024 3

关于VIO的ros代码作者没有提供;不过由于兼容了ORBSLAM2的一些函数,所以orbslam3中基于ros的视觉里程计代码理论上还是能跑的,不过要改一些变量名,命名空间杀啥的。。

from orb_slam3.

Sunchanghao avatar Sunchanghao commented on June 8, 2024 3

关于VIO的ros代码作者没有提供;不过由于兼容了ORBSLAM2的一些函数,所以orbslam3中基于ros的视觉里程计代码理论上还是能跑的,不过要改一些变量名,命名空间杀啥的。。

好的吧 再等等先

from orb_slam3.

dimaxano avatar dimaxano commented on June 8, 2024 2

As I see this code uses ORB_SLAM2 class, not ORB_SLAM3.

from orb_slam3.

saimouli avatar saimouli commented on June 8, 2024 1

@Sunchanghao I see that authors have already provided a ROS example: https://github.com/UZ-SLAMLab/ORB_SLAM3/blob/master/Examples/ROS/ORB_SLAM3/src/ros_stereo.cc

from orb_slam3.

mirellameelo avatar mirellameelo commented on June 8, 2024

+1

from orb_slam3.

Sunchanghao avatar Sunchanghao commented on June 8, 2024

As I see this code uses ORB_SLAM2 class, not ORB_SLAM3.

Have you tested the effect?

from orb_slam3.

Sunchanghao avatar Sunchanghao commented on June 8, 2024

Also support for ROS2 (I'm maintainer on ROS2 navigation2, would love to do testing with this!) would be great. I'd like to make formally supported integrations with this and ROS2 with navigation2 (https://github.com/ros-planning/navigation2).

I see a few ORB-SLAM2 references that weren't changed: https://github.com/UZ-SLAMLab/ORB_SLAM3/search?p=1&q=ORB_SLAM2&unscoped_q=ORB_SLAM2

Do you intend to support this and improve on it or is this a one-and-done research project? I ask because if we do some integrations with navigation2 we'll likely make improvements and want to know if we should fork this for the ROS world or submit PRs back here if there's support.

good job!
therefor, the interface in the current vision is ORB_SLAM2?

from orb_slam3.

zhijianglu avatar zhijianglu commented on June 8, 2024

just change ORBSLAM2::System into ORBSLAM3::System, I can compile the code by catkin_make

from orb_slam3.

liuzhenboo avatar liuzhenboo commented on June 8, 2024

ORBSLAM3 haven't provide source code of vio based ros.

from orb_slam3.

zang09 avatar zang09 commented on June 8, 2024

I change the code 'ORBSLAM2' to 'ORBSLAM3' and success build and launch.
But there is no mono-inertial or stereo-inertial code in Example/ROS

from orb_slam3.

Sunchanghao avatar Sunchanghao commented on June 8, 2024

I change the code 'ORBSLAM2' to 'ORBSLAM3' and success build and launch.
But there is no mono-inertial or stereo-inertial code in Example/ROS

There also seems to be no odometer~

from orb_slam3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.