Comments (6)
65536 casted to unsigned 2^16 is 0.
No, we don't want to validate given numbers in TS later. User should be clever enough to know what uint16 means.
from mediasoup.
65536 casted to unsigned 2^16 is 0.
I suspected that was the culprit, thanks to confirm. Then based on the docs and the comment at https://github.com/versatica/mediasoup/blame/e226f2f9dfcb3124d6a472b051353f75b3959290/node/src/test/test-DataConsumer.ts#L114-L115, shouldn't it be ignored instead of casted / truncated / mod 2**16? Or that's what you mean by "No, we don't want to validate given numbers in TS later. User should be clever enough to know what uint16 means."?
from mediasoup.
It means that if user passes a wrong uint16 number it is internally truncated without checking it.
from mediasoup.
It means that if user passes a wrong uint16 number it is internally truncated without checking it.
So if it's bigger than 65535, it will be bounded to 65535, isn't it? Or will it be modulo 65536?
from mediasoup.
Modulo. 35536 becomes 0 as in the test.
from mediasoup.
Great, thanks to confirm :-)
from mediasoup.
Related Issues (20)
- Validation functions at `ortc.ts` file are modifying input data HOT 10
- io-uring not enabled in Linux mediasoup-worker prebuilt since it uses kernel 5.15 HOT 10
- Need kernel 6 capable Linux CI host to produce worker prebuilt with io-uring support HOT 1
- Windows CI jobs failing due to meson HOT 4
- [Rust] Unable to build mediasoup > 0.12 with Docker HOT 3
- Issues in Node tests HOT 3
- Worker hits ASSERT condition in production HOT 14
- About v3.13.15, io_uring, and liburing HOT 7
- [Rust] Worker panics when running with multiple workers HOT 19
- announced_ip can also be a hostname (not possible in Rust)
- Rename "announced ip" to "announced address"
- [Rust] `Box<dyn Error>` error types make mediasoup error handling annoying HOT 1
- Wrong handle of response in Channel.ts? HOT 1
- Fail to compile mediasoup fuzzer due to liburing HOT 21
- Fuzzer fails immediately due to abseil: AddressSanitizer: SEGV HOT 12
- (ABORT) RTC::RTCP::FeedbackRtpTransport::AddPacket() | failed assertion `baseSet': base not set HOT 4
- OpenSSL send buffer growing without bounds in DtlsTransport (worker memory leak) HOT 22
- Implement FLEX FEC - RFC 8627
- Memory leak HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mediasoup.