wdas / brdf Goto Github PK

View Code? Open in Web Editor NEW

2.0K 2.0K 361.0 6.55 MB

BRDF Explorer

License: Other

Shell 0.02% C++ 89.34% C 3.37% Objective-C 2.87% QMake 0.10% GLSL 4.16% CMake 0.11% Makefile 0.03%

brdf's People

Stargazers

Watchers

Forkers

davvid rgba32 kayru jeremyselan aselle mplanck progschj jciehl claudiocalabrese cbraley rcerise habaut sevenuphome maradatscha dboogert junghwanlim harmonical rudybear yupingzhang samana sungsoo a153702 shadercoder msgfx mlesin yesoce yonder projectasura arunvb huizhuo1987 j6rry uikit0 davidlee80 bvssvni admercs zhangxiao6776 21isgonnabeagoodyear samcake weidaru fengliancanxue vanish87 valhallateam leegoonz louisfeng wangganggreat mcanthony lealzhan satishgoda forestcats0214 eddygun minamic rhinew tylerrobertsondeveloper logtcn pcsljm arieleo jerry-jinfeng-guo dinkin jianguo90hou zxcq544 mathgraphic ezhangle tc-qaq cornerzhang mkae shenyuqing 0x61726b danhuynh0803 lokoseba albeforia alainlompo yoann01 momose-d lunaivory gllyyy yibojiang doppioslash galek whiskey0201 koshlo benardp wofdy hdachev bakerg zgpxgame alexxnica kryndex dforsten luisbarrancos ychding11 wighawag yoyonel tfart nicecapj yangchenvr jasonwinston suwvjiang caomw pclod qitsweauca

brdf's Issues

I cannot open MERL .binary BRDFs in the latest release version windows10 x64 i7

I've found the latest release version here:
https://www.disneyanimation.com/technology/brdf.html

Opening analytical BRDFs working well, but I'm unable to open any measured BRDFs from MERL database.

Here is a picture of what's happening:

In addition to the fix, It would be great to have a fresh released version.

Keep up the good work.

Warnings during build on OSX 10.10 due to deprecated functions and stuff

Deprecated functions:

/Users/marko/WC/GIT/brdf/src/brdf/IBLWidget.cpp:68: warning: 'gluErrorString' is deprecated: first deprecated in OS X 10.9 [-Wdeprecated-declarations]
        const char *errDescr = (const char *)gluErrorString(glErr);
                                             ^
/Users/marko/WC/GIT/brdf/src/brdf/IBLWidget.cpp:321: warning: 'gluLookAt' is deprecated: first deprecated in OS X 10.9 - "Use GLKMatrix4MakeLookAt" [-Wdeprecated-declarations]
    gluLookAt( lookVec[0], lookVec[1], lookVec[2],
    ^

/Users/marko/WC/GIT/brdf/src/brdf/IBLWidget.cpp:566: warning: 'gluOrtho2D' is deprecated: first deprecated in OS X 10.9 - "Use GLKMatrix4MakeOrtho" [-Wdeprecated-declarations]
    gluOrtho2D(0.0, (float)width(), 0.0, (float)height());
    ^

/Users/marko/WC/GIT/brdf/src/brdf/Plot3DWidget.cpp:176: warning: 'gluPerspective' is deprecated: first deprecated in OS X 10.9 - "Use GLKMatrix4MakePerspective" [-Wdeprecated-declarations]
    gluPerspective(FOV_Y, float(width()) / float(height()), nearPlane, farPlane);
    ^

Malformed header guards:

/Users/marko/WC/GIT/brdf/src/brdf/MainWindow.h:46: warning: 'MAIMWINDOW_H' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]

/Users/marko/WC/GIT/brdf/src/brdf/geodesicHemisphere.h:46: warning: '_GEODESIC_HEMI_H_' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]

Wrong expressions?

/Users/marko/WC/GIT/brdf/src/brdf/ptex/PtexUtils.cpp:48: warning: comparison of constant 2 with expression of type 'Ptex::MeshType' is always false [-Wtautological-constant-out-of-range-compare]
    if (mt < 0 || mt >= int(sizeof(names)/sizeof(const char*)))
                  ~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/Users/marko/WC/GIT/brdf/src/brdf/ptex/PtexUtils.cpp:57: warning: comparison of constant 4 with expression of type 'Ptex::DataType' is always false [-Wtautological-constant-out-of-range-compare]
    if (dt < 0 || dt >= int(sizeof(names)/sizeof(const char*)))
                  ~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/Users/marko/WC/GIT/brdf/src/brdf/ptex/PtexUtils.cpp:75: warning: comparison of constant 4 with expression of type 'Ptex::EdgeId' is always false [-Wtautological-constant-out-of-range-compare]
    if (eid < 0 || eid >= int(sizeof(names)/sizeof(const char*)))
                   ~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Linux build fix

Building brdf on Arch Linux 64 failed on my machine. Adding

LIBS += -lz -lGLEW -lGLU -lglut to src/bin/brdf.pro

fixed that issue. Would be great if you could add that.

Is it possible to use this tool with BTDFs (and thus with BSDFs) ?

I haven't seen any BTDF nor BSDF in the brdfs folder, so I'm wondering if this tool can be used to preview transparent/translucent materials, and how. I admit that accurate refraction cannot be expected from OpenGL --unless very advanced GPU coding is used-- but, even if refractions are non-accurate, reasonable good results (color-wise) could be achieved...

Who should I credit?

I'm including some images generated by this program in my thesis. Should I put WDAS as the author of this package, or Andrew Selle?

build fixes for OSX

Hey all, in case it's useful:

To build on OSX, I had to add -lz to the Makefile to pick up the zlib symbols. Also, I had to modify Paths.cpp to allow it to find files. I hardcoded my own path to get past that hurdle, so I'm not providing a patch here, there's probably a proper way to resolve the problem.

Couldn't render on Ubuntu 18.04

This error presents on my system. I don't see anything on the screen.
Compiler: g++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
Qt: QMake 3.1, Qt 5.9.5
GPU: GTX 1050Ti
Driver: NVIDIA 418.56

Console output

DGLShader: Error reading file ./shaderTemplates/Plots.vert
DGLShader: Error reading file ./shaderTemplates/Plots.vert
opening ./probes/beach.penv... OpenGL Error invalid operation (1282) in file ../../../brdf/src/brdf/IBLWidget.cpp:595
success
opening ./data/sphere.obj...  Time to load OBJ: 383 ms
success
DGLShader: Error reading file ./shaderTemplates/Quad.vert
DGLShader: Error reading file ./shaderTemplates/Quad.vert
libpng warning: iCCP: known incorrect sRGB profile
DGLShader: Error reading file ./shaderTemplates/Plots.vert
OpenGL Error invalid operation (1282) in file ../../../brdf/src/brdf/PlotPolarWidget.cpp:184
OpenGL Error invalid operation (1282) in file ../../../brdf/src/brdf/PlotPolarWidget.cpp:297
OpenGL Error invalid operation (1282) in file ../../../brdf/src/brdf/PlotPolarWidget.cpp:297

bug in brdf-1.0.0-win32: file upload attempts are unsuccesfull and result in instant program closure

Tried several times to upload a file from MERL database and never succeded. The program closes immediately with no error code (just "program malfunctionning" message). Could you fix it and also is it possible to simply put the C++ project on GitHub?

dont use glsl reserved keywords as variable names

i've made a few modifications to make the radeon driver (fglrx 12.9) compiles brdftemplateAnglePlotAlbedo.vert, and measured.func, ie don't use half as a variable name and proper float litterals (0.0)

Question about license - if I create derivative work, does Disney own it?

The license states that:

Subject to the terms of this license, including the license
conditions and limitations in section 3, each contributor grants you a non-exclusive,
worldwide, royalty-free copyright license to reproduce its contribution, prepare
derivative works of its contribution, and distribute its contribution or any derivative
works that you create.

If I create derivative work (i.e. fork on GitHub and make some modifications), does Disney own the copyright to the derivative work? If I create derivative work, am I granting Disney a non-exclusive, worldwide, royalty-free copyright license?

Fails to run on late 2009 iMac with "ERROR: 0:46: '' : version '130' is not supported"

Although the BRDF explorer built and ran fine (after a little .pro file tweaking) it fails when trying to get it to output a 3D graph with this:

ERROR: 0:46: '' :  version '130' is not supported
WARNING: 0:47: extension 'EXT_gpu_shader4' is not supported

System: late 2009-iMac running OSX 10.10 with additional libs installed via MacPorts
Graphics card built-in: ATI Radeon HD 4670 256 MB

Project ERROR: $prefix is undefined. Please pass prefix=<path> to qmake

Hello,

When I try to qmake then make install

I get this error :

cd src/brdf/ && ( test -e Makefile || /usr/lib/qt5/bin/qmake -o Makefile /path/to/brdf.pro ) && make -f Makefile 
Project ERROR: $prefix is undefined. Please pass prefix=<path> to qmake
Makefile:44: recipe for target 'sub-src-brdf-make_first-ordered' failed
make: *** [sub-src-brdf-make_first-ordered] Error 3

I tried doing this from : https://stackoverflow.com/questions/14639459/how-to-change-qmake-prefix-location :

qmake -set prefix /path/to/repo

But I still get the same error, so I don't know what to do... Please help?

wdas / brdf Goto Github PK

brdf's People

Stargazers

Watchers

Forkers

brdf's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs