wojtossfm / godot_scml_importer Goto Github PK

It has no effect on the running of the game, but the error reporting is annoying.

OS: Windows 11 x64
Godot version: 4.1 stable
addon version: 0.9.0, 0.9.1

Example Project:
scml_test_4_1.zip

Description:

1. Add SCML importer addon.
2. Copy and paste a Spriter Pro project folder into godot project folder.
3. Enable SCML importer addon.
4. See some error messages.
   
5. Open scml file by double-click.
6. Scml file opened, but not properly. (missing "hopper/idle", only "impacts/impact1" but not loaded properly either)

I'm just trying this out with Godot 4.0 and it doesn't work. I get syntax errors as well as api usage errors.

Thanks for this btw! Looking forward to trying it out if it ends up working on 4.0.

In #6 the parsing breakage from including character maps was fixed but there was no work put into checking whether they are handled correctly. This issue has been raised to see if it works correctly and potentially can be improved.

Most of the errors were a repeat of the first one here:

res://addons/import_scml/import_plugin.gd:202 - Invalid get index 'folder' (on base: 'Dictionary'). res://addons/import_scml/import_plugin.gd:202 - Invalid get index 'folder' (on base: 'Dictionary'). res://addons/import_scml/import_plugin.gd:202 - Invalid get index 'folder' (on base: 'Dictionary'). res://addons/import_scml/import_plugin.gd:202 - Invalid get index 'folder' (on base: 'Dictionary'). res://addons/import_scml/import_plugin.gd:202 - Invalid get index 'folder' (on base: 'Dictionary'). res://addons/import_scml/import_plugin.gd:404 - Assertion failed. scene/resources/packed_scene.cpp:1053 - Parameter "p_scene" is null. scene/resources/packed_scene.cpp:1053 - Parameter "p_scene" is null. core/io/file_access.cpp:807 - Condition "f.is_null()" is true. Continuing. core/io/file_access.cpp:807 - Condition "f.is_null()" is true. Continuing.

An older save file of the character did import, but only the first animation. Could be related to that older save file using less features, such as hitboxes, events, sound events or properties.

Project with issue submitted on #5 (comment)

Blocked by #6

While the effect on a single character is correct when multiple character cross this seems to break.

A solution seems to be:

• to not actually set the z-index
• instead use it as a guide when ordering the children for each parent

Seemed in the scenes where I tried it this led to the expected ordering visually being maintained while removing the issue of multiple characters crossing and sprites clipping over each other in awkward ways.

Here's a way to demonstrate the issue I mentioned. I've been tinkering with the animations from CraftPix, and you can reproduce the situation using one of their free downloads, such as the goblin from this set. In the download, you'll find Goblin/PNG/VectorParts, which contains the figure parts as well as Animations.scml.

The animations look fine in isolation; the problem only arises when crossfading between them, as the rotations will sometimes go "the long way around." There are different ways to reproduce the problem, but here's a particular workflow that I was commonly using.

1. With the SCML importer enabled (and this patch in place), import the goblin parts and animations as described above.
2. Open the Animations.scml file and create a New Inherited scene when prompted. Save that as a new scene, then remove the inheritance by right-clicking on the root of tree and selecting "Clear Inheritance." This is required to be able to edit the animations.
3. In the AnimationPlayer node, disable looping on the Idle and Walking animations.
4. Create an AnimationTreePlayer node. Connect the AnimationPlayer to it. Make its root node into an AnimationNodeStateMachine.
5. In the state machine, add the Idle and Walking animations, then add automatic transitions to go between them that change at the end of the animation. (That's why the looping was removed above.) Set the animation tree player to Active.
6. Add a crossfade (e.g. 0.2 seconds) between the animations. Now you will be able to see that the change between animations has the head spinning almost a complete circle.

I hope that helps!

Originally posted by @doctor-g in #21 (comment)

I cannot find the "Import SCML" button, can you make a little tutorial, please?

Thanks.

I'm testing this out for the first time and I'm running into these errors any idea what caused them?

Trying to import the following project, generate wrong scene

https://drive.google.com/file/d/1XdxASfW5ILD8Yxi_M3aJfb3R_c45V96E/view?usp=sharing

With the changes that came from #21 the rotation logic now has a bit of a split brain issue dealing with both degrees and radians in the code.

This should be adjusted to attempt to focus on one.

There are cases where between animations items may move between parents. This is currently not supported and needs work.

Broken out of #7

related to #13