xavi- / beeline Goto Github PK

Hi,

Any plans or thoughts on making the regex matching support named subpatterns, so that we get not just the values but also the names of the "parameters", like in tokens, in the callback?

I realize this might require depending on another regex library than the core one. It would just be useful, I use named subpatterns/capturing groups all the time.

Thanks!

Hi Mate,

I am trying to make some additions to allow a cache max age to be optionally settable on static files but I cant get the tests to run. Can you let me know how you are running them?

I was going to convert them over to use tape and npm test but I didn't want to do so without making sure I can run them first.

How do I access POST parameters?

If one specifies mimeTypes without a leading dot, as the README tells you to, the file will be served without content-type.

The check for a valid file-request tests the file extension both with and without the leading dot. But later, when the mimeType is served, a mimeType with a leading dot is assumed.

My personal opinion is to be strict about this: require the dot to be present when one specifies the valid mimetypes, since this is the way that path.extname works.
Strict is (almost) always good. Strict keeps us from producing software like IE ;)

Btw, thanks for a neat router!

Hi,

First, thanks for writing beeline!
Like its simplicity and usefulness.

Having said that, simplicity in this case should not come in the cost of security, right now (unless I missed something) beeline will allow you to go up the directory tree, for example:
http://localhost:8080/static/../../../log.txt
or worse still
http://localhost:8080/static/../../server.js (!!)
I started at looking to fix this issue in the code, but could not get the tests to run, can you please advise how to get them to run?