yy / dviz-course Goto Github PK

@rachithaiyappa - please update m14 instructions to match installation instructions for gephi 0.9.3:

It's mostly you don't need to download javascript anymore.

https://gephi.wordpress.com/2022/04/10/gephi-0-9-3/

Professor @yy, I noticed while working on some PRs (#51 and #48) that the repository doesn't have squashing enabled yet. Squashing is nothing but combining all the commits of the PR into a single one and merging the PR as a single commit. If this is something that you think is helpful, then you just need to enable the squash merging in the repository setting.

Once this feature is enabled, we don't need to do anything else. From next time onwards, You will see option Squash and Merge on all PRs. Instead of just Merge, you can click on Squash and Merge and it will squash all the commits into single commit.

Advantage of Squash Merge:

• Experimental commits to test features must not be committed while merging and only the final result of all commits in PR should be merged as a single commit.
• If PRs have a high number of commits and if we keep merging that, then the .git history size will become very huge in just some months. It will be many times more than the actual repository code itself.

Please close this issue once you see this.

Professor @yy , I have recently raised PR to add one of the feature and noticed that we currently don't have anything which can tell us the diffs in the notebooks changed in case somebody raises a PR. But there is a way in which we can setup a github workflow which will tell the changes in notebook same way git VCS works. We can use ReviewNB for that. Let me know how this idea sound to you. If you think it will be helpful to us, then I will be happy to start working on that.

Professor @yy , Currently we don't have any workflow to test the syntax of the code being contributed to notebooks. I understand that these notebooks are just work assignments and probably may not require thorough testing. But when I ran pytest over all of the notebooks. I found that there are lot of syntax errors (or may be intentional code skip). I am attaching the image of one of such findings.

More than half of the notebooks are showing some syntax errors in them. Do you think we need automation to test the notebooks whenever the new PR is raised? If yes, then we can start the work on that.

Hello, I have made a port of the course with mkdocs. The repository is at fralfaro/dviz-course and the documentation is at fralfaro.github.io/dviz-course.

I hope this can centralize the course, to improve the learning experience.

Professor @yy , I found a link which is broken m01. A simple IPython notebook that explores the map and Voronoi diagram is broken. I couldn't find it anywhere on this repo. So, requesting you to fix it or send it here and I will be happy to raise PR.

Professor @yy, We have previously seen such a scenario in #34 where we found the broken link while manually reading the material. Instead of relying on manually checking the links after a certain duration, it is good to have a workflow to check links' health status.

As part of the new PR #53, I have added that workflow. After running the workflow, I found out some of links are broken. I have listed all of the broken links with paths below:

• m03-integrity/class.md
  • 
    • Above image is accessible if you click on the link, but we can't access it from workflow because it is stored on the amazon server and maybe they are returning XML which will not be compatible with HTTP requests. To solve that, what we can do is, we can store the same image to our dropbox publically or in the code repository itself and we can use that link. (Happy to raise the PR to do that).
• m04-perception/class.md
  • Bang Wong, from "Points of View" (they are very short columns): http://clearscience.info/wp/?p=546
  • Weber's law and thresholds
• m05-design/class.md
  • Bateman et al., Useful junk?: the effects of visual embellishment on comprehension and memorability of charts
  • Borkin et al., What Makes a Visualization Memorable?
• m12-maps/class.md
  • What's the best map projection?
  • R. Knippers: Map projections