zeno-zr / pe Goto Github PK

this might be nitpicking but some of the images are quite blurry

minor cosmetic issue, the line on the box gets cutoff in the DG. this happens several times in the DG

when adding two items from two catagories and catagory :

Small grammar error: Might be better to say: In total, there are of catagories. Very low severity as it is cosmetic

testing dummy

in windows, the command terminal can refer to the Command Prompt or Powershell, for unix operating systems, terminal.

when i have many users, it seems that the json file is created in the same location as the jar file. as such, it might be hard to search for the file, especially if i have other things in the folder.

it might be good to create a folder called "jsondata" or something similar to store the data so it makes it easier to find specific json file

The green c and the red and green shapes meant to represent private and public variables/methods are not part of the class diagram style. this happens throughout the DG

In the UG, it states that we can have an overview for the year, or a specific month & year.

i think it will be good to add a way to search for all the expense in a month across all the years. for example, overview DECEMBER.

this could be useful for people who want to track how their spending in that particular month has changed over the years (e.g.: has my annual overseas holiday trip getting more expensive?)

some people might want to use their name for the username, and those names might have special characters. it would be good to have a way to have this feature inside.

if including many special characters makes input hard to parse, you can try giving user a limited number of character, maybe '-' might be good as seen on the cs2113 website here for names

somewhat related to the bug about special characters. it seems that there is way to have special characters in names despite not allowed in the UG. this is done by directly editing the userlist file.

the command given works for the file if downloaded directly from the release, but if the user changes the name of the file, they may not realise that the specific command given to run the file in the UG does not work anymore.

maybe change is to java -jar .jar and give an example: java -jar tp.jar

class diagram too cluttered in DG.

It might be good to split it up into two diagrams for ease of viewing. I had to zoom in a lot to see the details in the classes.

sometimes, when i type fast and misspelled my username (say jane), I cannot go back and edit it. instead I have to type a wrong password (like a space) to exit and retype.

for a user used to CLI, it will be easier if i can go back and edit my input.

for example: login username/jane password/12345678

this way, i can edit jaane to jane before i enter my password, which makes login an easier process

in the program, a strong password just means it must be longer than 8 characters, which by today's standard isn't that strong. earlier on, i was able to create an account with the password 12345678

It seems that the application is allowing dates from 1981 to the current year. so in this case it might be good to indicate that it is that rather than putting 2023 just because this guide is written this year.

as seen here, the guide here implies 1981 to the current year:

but format suggests only up to 2023.

testing out CATcher right before the PE