zeroprophet / klefki Goto Github PK

Describe the bug
ImportError: cannot import name 'EllipticCurveCyclicSubgroupSecp256k1' from 'klefki.algebra.concrete'. It seems it is missing in the-path-to-klefki/klefki/algebra/concrete.py.

To Reproduce
Steps to reproduce the behavior:

1. simply type klefki shell in shell terminal, and it produces the import error.

Desktop (please complete the following information):

• OS: macOS 14.4
• Version 1.7.1

Hi

Just to let you know that you should remove any references to OP_PUSHDATA3 as its not part of bitcoin script. Only OP_PUSHDATA1, OP_PUSHDATA2 and OP_PUSHDATA4 are valid.

https://github.com/bitcoin/bitcoin/blob/master/src/script/script.h#L59-L61

Your project looks fine, but I can't get it to work.

① The demo you provided cannot be run.
https://replit.com/@RyanKung/Klefki-Demo

② pip install klefki
klefki shell
After performing the above operations, an error will be reported：
Error：
root@autodl-container-f77d11adac-eb7b502d:~# klefki shell
Traceback (most recent call last):
File "/root/miniconda3/bin/klefki", line 8, in
sys.exit(main())
File "/root/miniconda3/lib/python3.8/site-packages/klefki/client/shell.py", line 66, in router
return fn(*args, **kwargs)
File "/root/miniconda3/lib/python3.8/site-packages/klefki/client/shell.py", line 21, in shell
from klefki.algebra.concrete import (
ImportError: cannot import name 'EllipticCurveCyclicSubgroupSecp256k1' from 'klefki.algebra.concrete' (/root/miniconda3/lib/python3.8/site-packages/klefki/algebra/concrete.py)