zhengchaolei / allstats Goto Github PK

What steps will reproduce the problem?
Have a replay with french in chat log (like "ça")
Go to game info page and display game log

What is the expected output? What do you see instead?
Have a correct display of "ça". Instead, I got "ça"

What version of the product are you using? On what operating system?


Please provide any additional information below.
I change the charset to utf8 and everything is working.

Utf-8 support for Russian language etc.

What steps will reproduce the problem?
1. Top Players
2. Arrange by Kills/Death

What is the expected output? What do you see instead?

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result
resource in /var/www/localhost/htdocs/web/top.php on line 579

Warning: mysql_free_result(): supplied argument is not a valid MySQL result
resource in /var/www/localhost/htdocs/web/top.php on line 619


What version of the product are you using? On what operating system?
Latest on Gentoo Linux

Please provide any additional information below.

there are missing duplicates for following heroids:
H08D
H084

The server that we run ghost++ on was restarted (safely, to do maintenance, 
kernel upgrade). When it came back up, everything appeared fine for all the 
existing games. It's pulling the old games fine from MySQL, replays download etc

For all new games, it shows nothing:
http://resistance.kiwilan.co.nz/allstats/?p=gameinfo&gid=805
The last game that worked was:
http://resistance.kiwilan.co.nz/allstats/?p=gameinfo&gid=801

Currently running 1.4.156
Linux resistance 2.6.24-11-pve #1 SMP PREEMPT Fri May 14 09:28:08 CEST 2010 
i686 GNU/Linux
MySQL Server version          5.1.45-3
resistance:~/ghost++# apache2 -v
Server version: Apache/2.2.15 (Debian)
Server built:   Apr 25 2010 08:53:27

Any help would be greatly appreciated.

I can see in phpMyAdmin the new games data is being populated, so thats why I 
think it's just allstats not pulling it?

What version of the product are you using? On what operating system?


Please provide any additional information below.

GhostOne the GUI version of Ghost++ has implemented a safelist system, i've 
made a safelisted users page based on the admins page, is it possible to insert 
it into the project?

I've added also the following variables:
$safeResultSize ($adminResultSize)
$showSafe ($showAdmins)

And the necessary phrasses (english only).


I've also added a new variable $commandTrigger = '!' because not everybody uses 
! as a command trigger (to be shown in admins page commands).

user statistics page: if there are games which were ended by !end command
then most played hero can be ""  (+ tries to load img/heroes/.gif)

http://forum.codelain.com/index.php?topic=4752.msg70440#msg70440

What steps will reproduce the problem?
1. Open User Stats for a single user.

What is the expected output? What do you see instead?
Loading times should be shown.
Instead there is a 0.00/0.00/0.00 output an a error message in black on
black background

What version of the product are you using? On what operating system?
allstats r71

Please provide any additional information below.
fixed the bug in user.php
~line 275
$sql = "SELECT MIN(datetime), MIN(loadingtime), MAX(loadingtime),
AVG(loadingtime) FROM gameplayers LEFT JOIN games ON
games.id=gameplayers.gameid LEFT JOIN dotaplayers ON
dotaplayers.gameid=games.id AND dotaplayers.colour=gameplayers.colour LEFT
JOIN dotagames ON games.id=dotagames.gameid WHERE name='$username' AND
winner!=0";

and ~line 375
$sql = "SELECT MIN(datetime), MIN(loadingtime), MAX(loadingtime),
AVG(loadingtime) FROM gameplayers LEFT JOIN games ON
games.id=gameplayers.gameid LEFT JOIN dotaplayers ON
dotaplayers.gameid=games.id AND dotaplayers.colour=gameplayers.colour LEFT
JOIN dotagames ON games.id=dotagames.gameid WHERE name='$username'";

What steps will reproduce the problem?
1. link to the code on project home so people don't have to sift through 60
pages of noobs asking about mysql to find the latest update
2.
3.

What is the expected output? What do you see instead?
expected to find code here, did not.

it can be more flexible to add language file to this stats, coz its very 
offensively to get a new version everytime with english language by default

I play a lot as Pudge, and semi-regularly deny myself (2-5x a game).

Looking at the score formula:
$scoreFormula = 
'((((kills-deaths+assists*0.5+towerkills*0.5+raxkills*0.2+(courierkills+creepden
ies)*0.1+neutralkills*0.03+creepkills*0.03) * .2)+(wins-losses)))';

This doesn't mention suicides or where a team-mate denies you (If you're doomed 
for example, or poisoned).

It shows up in the Replay Game Log as:
%username has killed himself!

It's technically a "death" in-game, and shows up in the amount of times you've 
died, but you still deny the enemy Gold / XP, yes?
Is this something that can be adjusted at the Allstats level, or does this need 
to be reworked in the map itself?

What steps will reproduce the problem?
1. install allstats
2. run it
3. check error.log in apache

What is the expected output? 
nothing

What do you see instead?
error variable undefined displayStyle

What version of the product are you using? On what operating system?
last version on linux 

Please provide any additional information below.
There is missing the declaration global $displayStyle in the function
printStatsRowType of the file functions.php, adding it resolved the problem.

There is a problem when a game is ended with .end / .endn in ghost, the 
dotaplayers database is not updated, but dotagames, games and players do.

This results in a bug when you calculate the some stuff, like the most used 
hero (this is particularily notorious in players with few games and most of 
them with forced ending). And there are games shown that are empty, wich is 
pretty useless.

What steps will reproduce the problem?

1. I simply erase the unwanted games from the database. 

$sqlQuery1="DELETE FROM games WHERE map LIKE '%DotA Allstars%' AND id NOT 
IN (SELECT gameid FROM dotaplayers GROUP BY gameid)";
$sqlQuery2="DELETE FROM gameplayers WHERE gameid NOT IN (SELECT id FROM 
games GROUP BY id)";
$sqlQuery3="DELETE FROM dotagames   WHERE gameid NOT IN (SELECT id FROM 
games GROUP BY id)";

2. A better solution would be to exclude from the queries this games. What 
you can use to recognise them is that this games are dota games but do not 
have any dota player. Also they do have dotagames.min=0 and dotagames.sec=0 
either one of this two can be used, (i preffer the first one) 


What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
Latest version at the moment which is 1.4.149.
Using Windows XP SP2

Please provide any additional information below.

New DotA 6.68b map version with new heroes / items

See: http://www.getdota.com
http://www.playdota.com/changelogs/6.68b

Currently games played with 6.68 or 6.68b are not shown at all.

What steps will reproduce the problem?
Nothing to reproduce

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?
Ghost++ version 14.2
mysql 5.0.1
ubuntu 9.04


Please provide any additional information below.
in the new dotaversion the colour codes changed. Thus the stats that use
the colour codes to identify players in a certain game are corrupt.

Example:
before version 6.61c host colour was blue and code was 1. Now host colour
is red and code is 0. Thus the stats for player with colour code 0 do not
occur.

I have installed dotastats on http://d0ta.de/dotastats. If you search for
player kungfuzius my last game played was 2009-08-06. But I played my last
game tonight. If you look the game history there are only 8 players in the
game and it shows that it was a 5v3 game. That is not correct. It was 5v5
and the creator kungfuzius does not show up in the game details which is
also not correct.

waiting for new heroID and new hero icons

tnx

What steps will reproduce the problem?
1. Click the Bans Page.
2. Click Filter by Date twice so that the most recent date should be first.

What is the expected output? What do you see instead?
You should see the most recent Bans in date order. Instead it is showing
alphabetical, then by date.

What version of the product are you using? On what operating system?
Most recent? Not sure how to check I svned it on 7/11/09. XP Pro. Mozilla
Firefox 3.5.

Please provide any additional information below.
Also it would be really nice if the date field showed the complete date
(include the time).

Otherwise the site looks really good. Keep up the good work.

What steps will reproduce the problem?
1. Start a game that has a name which contains special characters such as
">" or "<".
2. After game has finished go to game history and open the game-item.

What is the expected output? What do you see instead?
There is no replay download / game log because ghost renames the replay...

What steps will reproduce the problem?
1. Download latest version 1.4.156.zip file directly to linux server using:
wget http://allstats.googlecode.com/files/Allstats-1.4.156.zip
2. unzip Allstats-1.4.156.zip and move to www directory
3. Changes only to top part of config.php relating to mysql db

What is the expected output? What do you see instead?
?p=hero&hid=Ewar&s=kdratio&o=desc&n=0
Previously would show the Phantom Assassin Icon
Affects:
Phantom Assassin
Phantom Lancer
Dragon Knight
Tinker
Soul Keeper (Terrorblade)

Also doesn't show new items or hero icons

What version of the product are you using? On what operating system?
1.4.156
Debian

Please provide any additional information below.
Appears as though the case of the files has changed:

resistance:/var/www# find ./ | grep -i ewar.gif
./Allstats-1.4.149/img/heroes/Ewar.gif
./Allstats-1.4.156/img/heroes/EWAR.gif
See (1.4.156):
http://resistance.kiwilan.co.nz/allstats/?p=hero&hid=Ewar&s=kdratio&o=desc&n=0
vs 1.4.149:
http://resistance.kiwilan.co.nz/allstats.old/?p=hero&hid=Ewar&s=kdratio&o=desc&n
=0

What steps will reproduce the problem?
http://www.d0ta.de/dotastats/?p=monthlytop&n=4&i=Month
If the game is not full (no 5v5) the missing players get gold (I don't know
why). In "-em" games that last long, they have more gold in the end than
regular players.

What is the expected output? What do you see instead?
Expected output is that there are no NULL values.

What version of the product are you using? On what operating system?
allstats version 1.3.138, Ubuntu 9.10

Please provide any additional information below.
The code that is responsible for the null values (mysql):
"SELECT original as topHero, description as topHeroName, gold as topValue,
b.name as topUser, a.gameid as topGame FROM dotaplayers AS a LEFT JOIN
gameplayers AS b ON b.gameid = a.gameid and a.colour = b.colour LEFT JOIN
games as c on a.gameid = c.id LEFT JOIN heroes as d on hero = heroid LEFT
JOIN bans on b.name = bans.name where YEAR(datetime) = '2009' AND
MONTH(datetime) = '9' AND bans.name is null ORDER BY topValue DESC, a.id
ASC LIMIT 5"

Code that solves the issue (Just add "description is not null in where clause):
"SELECT original as topHero, description as topHeroName, gold as topValue,
b.name as topUser, a.gameid as topGame FROM dotaplayers AS a LEFT JOIN
gameplayers AS b ON b.gameid = a.gameid and a.colour = b.colour LEFT JOIN
games as c on a.gameid = c.id LEFT JOIN heroes as d on hero = heroid LEFT
JOIN bans on b.name = bans.name where YEAR(datetime) = '2009' AND
MONTH(datetime) = '9' AND bans.name is null and description is not null
ORDER BY topValue DESC, a.id ASC LIMIT 5"

Every item duplicate has its own graphics file.

Using a database table that resolves duplicate item-ids as already
implemented for heroes would solve this!

What steps will reproduce the problem?
1. Watch stats for players who switches during game.

What is the expected output? What do you see instead?
Wins and losses should be calculated correctly.
Since there are errors in several SQL statements, there are wrong results
displayed. For switched players losses are counted as wins and wins are
counted as losses. (Maybe there are other side-effects)

What version of the product are you using? On what operating system?
r71

Please provide any additional information below.
Fixed some statements.
See Forum Postings for details:
http://forum.codelain.com/index.php?topic=4752.msg56759#msg56759
http://forum.codelain.com/index.php?topic=4752.msg56893#msg56893

What steps will reproduce the problem?

When playing in SP (shuffle players)mode

What is the expected output? What do you see instead?

the game log looks like it wasn`t SP(it includes that some kills looks like
denies), it must reorganize the teams and the players colors.

What version of the product are you using? On what operating system?
1.4.146 in windows xp, appserv

I have noticed that the Heart of Tarasque is shown as disabled. Actually,
il seems that item id I0KL is a HoT and not a disabled HoT.

Find and delete duplicate hero symbols.
Enhance hero table -> add all duplicates.

Any games at the moment are recorded. Sometimes all but a few players leave 
just to "boost their stats" and sit at the Throne getting kills every couple of 
seconds.

What would be nice is a config option that hides certain games, based on a 
variable, such as games that have more than a total of X number of kills on a 
team, or X number of kills for a player are automatically discarded either by 
hiding them, or pruning the ghost db

It seems like the 6.72 branch is going stable pretty soon. Is there any change 
AllStats will be updated for new items & heroes on this patch?
Would be cool, loving allstats!

Will Allstats be updated for 6.69* map, with new hero icons (Bristleback etc) 
and other changes?

Or will you wait for 6.70?

Hi guys:
I'm using Allstats for several months, each day there will be 100-200 games
hosted by my Ghost++ bot, now I've about 20,000 games in the database (the
gameplayers & dotaplays' tables have 200,000 records).

When we do the top plays query (joined several tables), it will timeout.
Will you consider the performance of some queries in the future versions?
Thanks for your amazing work :)