clsid2 / mpc-hc Goto Github PK
View Code? Open in Web Editor NEWThis project forked from mpc-hc/mpc-hc
Media Player Classic
License: GNU General Public License v3.0
This project forked from mpc-hc/mpc-hc
Media Player Classic
License: GNU General Public License v3.0
This started happening in 1.7.13.60 (issue does not present itself in 1.7.13.32). Steps to reproduce:
All these tests were done using x64 standalone builds. OS: Win 10.0.17134.345 x64.
If subtitles are encoded in ANSI format then Precomposed ellipsis (three dots as one character) is not always displayed. It works fine if subtitles are encoded in UTF-8 format. It also works in some other players like SMPlayer, VLC or old MPC. But some players, including yours, have some problems.
Example:
1
00:00:00,000 --> 00:01:00,000
A) Text … text
B) <i>Text …</i>
C) Text …
Precomposed ellipsis is displayed in case A) and B) if there is something after the ellipsis, but it's not displayed in C) case. https://drive.google.com/file/d/0B8fWfubhb52fekZicUF3WDZhUGxIclZIVVdYZnJrNWxhMno0/view?usp=sharing
I don't know what could cause this problem/bug? I tried different players, some have this problem, some don't. I have Win 10 Pro 1803 if this is somehow related.
In commit 0d5ddc8, src/mpc-hc/MainFrm.cpp, line 17237. CreateProcess returns two handles in the PROCESS_INFORMATION structure (hProcess and hThread) that need to be closed; right now, they are leaking when the DownloadWithYoutubeDL-function returns.
For some reason youtube-dl or mpc-hc won't reconnect and resume if I stop playback for some hours or so.
Hi there,
I have tried to install the latest version v.1.8.4 onto my system and it said Windows XP is not supported. I don't really see why you are removing the support for an operating system that is still in use by even more people that use Linux and there are not even any new features that would give a good reason to drop XP support.
Media Player Classic is the only light, fast still full-featured media player out there for Windows. People on XP are mostly on older computers with less resources and no drivers for newer operating systems (like Vista, 7 or 10). If upgrade was an option it would have already happened in the last 4 years.
Please revert c04cff832a7aa4f705e4bd7a56f158e7144ea817 and bring back Windows XP support.
Is it possible to build a version of mpc-hc that can use the aacs ;ib to play bluray discs?
Back in 2016 I reported this in a commit: mpc-hc@3058daa#comments but it went to the void and was never fixed. @clsid2 if you could take a look I'll give many thanks. Thank you.
PS: What does this commit from kasper93 do? kasper93@185bd36
I want to record some VHS videos through USB video captures. But there are only a few encoder options in current version, and also I cannot find a way to set the parameters (e.g. bitrate) of them. I hope you can add more encoders, such as x264 and NVENC.
Hi.
Is it possible to remember last window positions of previously opened instances of MPC-HC?
Very often it needs to open several windows in their certain positions and it's very inconvenient to rearrange them every time.
Updating from 1.7.13.112 to 1.7.18, I noticed significantly decrease of seeking performance. Previously it was nearly instantaneous, now it takes usually like 2 seconds, sometimes even more. It's as fast as normal seeking, so I suspect it uses normal seeking instead of fast seeking.
After trying several versions, the regression has been introduced in 1.7.16.
Hy to all.I use MPC-HC .The problem is with wassapi sound output on VIA 1705S soundboard.When use wasapi exclusive mode bit perfect the bass is not redirected to subwoofer on 5.1 speaker configuration.
Hi @clsid2
Thank you very much for the great work you've done on mpc-hc. Maybe a bit of information request and a feature request there.
I'm integrating mpc-hc into my Win10 ISO to make my life easier. I found a switch /verysilent
(link) that seems to do the job but I can't find any reference to it into the code. I'm curious to understand if the installer has other useful switches I could leverage ?
Alternatively and as a feature request, would you have any interest in providing a customised and automated install like it's done with the Firefox Installer? It could be great to have the ability to tweak on mpc-hc is installed.
Thank you and Merry Christmas.
MPC-HC can no longer play a video from an URL address such as a sample video on http://jell.yfish.us/ because the program tries to open it with youtube-dl, which results in an error.
The link can be opened with the previous version of mpc-hc.
First of all, thanks for continuing the works with what you can.
Is there any way that you could review/merge @xpc1000's PR (mpc-hc#145) ?
Please modify the default update check address.
With the new update I randomly (but very consistently reproduced) experience a silent crash when seeking certain video files; mainly with the keyboard keys (holding the arrow keys or even pressing HOME or PGDN once to jump). The results vary according to the video codec. Audio files don't crash from what I've seen. For example, a file with Video: MPEG4 Video (H264) 1280x720 23.976fps [V: AVC (720p) (h264 high L4.1, yuv420p, 1280x720)
crashes very often, while Video: MPEG4 Video (H264) 1280x720 23.976fps 1530kbps [V: h264 high L4.0, yuv420p, 1280x720, 1530 kb/s]
doesn't at all. Another video I have crashes less often when seeking. Files with the first codec (for example) very often crash immediately on opening as well (or when seeking to the beginning by pressing HOME key). Usually silently, though very rarely this error appears see here.
I've narrowed down the bug to the LAVFilters build in the MPCHC 1.8.1 release: if I use the 1.8.1 release but only replace all the files from the LAVFilters folder from the MPCHC 1.7.18 release, the problem goes away. I didn't even delete the folder first.
I'm not sure exactly where to report this to LAVFilters devs...
I'm on 64-bit Windows 10 (and 64bit MPCHC). A friend also with Windows 10 reproduced the same results. Can give more info if needed.
Hello,
my issue affects the 1.7.17 release version; I have seen that there has been another commit dealing with seeking since then (in particular, the line " -#define MAX_FASTSEEK_INACCURACY 200000000LL", the only line that seems to contain an explicit reference to 20s, is gone), but I don't know if this has fixed the problem as I don't have a build with this commit, so I'll nevertheless state it here:
Seeking forward and backwards to the next/last keyframe (I mean the thing that is on Shift+Left/Right Arrow by default) is broken if the next/last keyframe is more than 20s away. It just doesn't seek forward at all if the next keyframe is more than 20s away; and if seeking backwards and the last keyframe being more than 20s away, it seeks 1ms backwards. And if I do this often enough (so that the last keyframe is only 20s away), it finally seeks to the keyframe that I wanted to reach.
Thanks for the continued effort you put into MPC-HC.
Greetings
mkver
Hi.
During the playback of Twitch streams in MPC-HC, after minimizing the MPC-HC window on monitor#1 an interruption in audio and video streams is initiated until its ultimate stop. Youtube streams only have some interruptions in audio and video but not stop. At the same time nothing happens while minimizing on monitor#2.
I have a quick question..
You may or may not know what Chocolatey is, but we have had a question over there about the currently Chocolatey package for MPC-HC (https://chocolatey.org/packages/mpc-hc). Chocolatey allows the installation of this software application by simply using the command choco install mpc-hc
. Now, the question that we have had is about your fork of the MPC-HC application. Would you consider your fork as being known as a different name? Or is it still the same application?
The reason that I ask is that we have been asked to try to push the new releases of your fork to the Chocolatey package id of mpc-hc
, however, your application is a fork, so I am not clear or whether this is the correct course of action, even though you have continued the versioning numbering in your fork.
My concern is that if the original mpc-hc application starts development again, and in the meantime we have pushed the new versions of your fork to the same package id, then there would be a conflict.
I would love to hear your thoughts on this matter. Thanks in advance!
Hi, sorry to use this to make a question but github has no system to exchange msgs, i wanna know where i go to translate mpc-hc to pt_BR? There is no info in the main page about that, i already went to transifex and put myself in the list to translate it but the page is inactive. If there is another way i'll put the translation here if you dont mind.
Seeking on certain part of the video, video frames delayed, audio plays normal for many seconds. Noticed on some videos on quite random parts.
Sample: https://www37.zippyshare.com/v/IG9fJ1Eb/file.html, seek on 05:58, delayed about 7 seconds
I test using v1.7.13 and v1.8.2. Regards.
Default OSD Font is face name of system font.
https://github.com/clsid2/mpc-hc/blob/1.8.4/src/mpc-hc/AppSettings.cpp#L1414-L1416
But setting combo box labels are full names of fonts.
https://github.com/clsid2/mpc-hc/blob/1.8.4/src/mpc-hc/PPageTweaks.cpp#L79
So in some environment, setting combo box is not selected correctly.
(ex. FullName=Yu Gothic UI Regular, FaceName=Yu Gothic UI}
Can you, please, add an option to save Youtube-DL stream with the same quality of the one currently playing?
e.g. : Currently, if I play a 480p stream (set with the YDLMaxHeight parameter), the stream saved is a 1080p one.
Thanks!
It seems that currently, using ALT-I (File->Save Image) in a video always saves an image of the current frame in the current dimensions of the player window - exactly as the user sees it. So the output image includes the downscaling, upscaling or the black bars, accordingly. There is no option to manually select or type the target resolution you want.
This is actually a big issue in scenarios where you want a target resolution that is bigger than the maximum size that you can get the player window to. For example, assume that I want to save snapshots of videos in their original resolution, and my monitor and OS resolution is 1920x1080. If I open a 720p video, I just need to press ALT-2 (ensures the window size is the same as the size of the video) to resize the window, then press ALT-I to make the snapshot, and I get a 1280x720 image, accordingly. Now if I open a 1080p video, then using the previous method is not enough (the player window size doesn't actually cover the whole screen, because of the GUI and aspect ratios), to same a full-size image I must go to fullscreen first instead, so the sequence is ALT-ENTER and ALT-I. Well, that works.
The problem is when, say, I'm on my laptop with a monitor with the native resolution of 1366x768. Then I can save a full-size snapshot of a 720p video as per above, but I can't do so with a 1080p video, since even fullscreen I'd only save a downscaled 1366x768 image. Couldn't find a way to work around that with no amount of messing around (I can't even increase my OS resolution further, at least normally). So either I'm missing something crucial or it's a crucial oversight, and the 'Save Image' feature should have an option to manually change/select the output image's resolution (slightly more useful to allow customizable values in case someone may want like a 1500x843 output or something).
This issue may or may not be also relevant to the 'Save Thumbnails' feature.
On that subject, this reminds me/confirms that the image (/"screenshot") taken is always the result of what the player decodes and displays to the user during normal playback including any filters and processing done to the frame - would it be possible, if it's not particularly time consuming, to add an additional option/checkbox be added to save a screenshot as a mere 'frame extraction'. without the application of extra processing? Both approaches have their uses. I am pretty clueless as to whether that'd be much more work than I imagine and not worth it for this program, though.
I've been facing this issue for years now. Finally decided to do something about it. I searched for an updated version of the beloved MPCHC and found this repo. I thought that by updating to this new version, the issue might resolve itself. It hasn't.
So this is a very weird issue. Let me try to explain it.
On a fresh system startup (Core i5-4670K @ 4.5Ghz, 16GB 1600Mhz, Radeon RX480, Content on HDD) everything is fine. Videos load almost instantly, seeking is smooth. However, sometimes (every time basically), usually after I've opened another big application (a game for instance) and closed it, this issue starts to happen.
The issue? A 2-3 second time window on file opening where my computer turns into a slide-show while the video loads. Everything turns into a slideshow - including the mouse movement or any other apps running in the background. I've tried this with various files. Seeking also becomes very sluggish (bigger delay in response to movement of seekbar).
The only way to fix the issue is by using Old Video Renderer but that doesn't display video for many formats and doesn't support most advanced features.
I'm currently using a fresh installation of version 1.8.4. I have not modified any settings.
If any info is required (system related), do let me know. Here's a sample MediaInfo from one of the files I was playing:
General
Complete name : F:\Aloha (2015) [1080p]\Aloha.2015.1080p.BluRay.x264.YIFY.mp4
Format : MPEG-4
Format profile : Base Media
Codec ID : isom (isom/avc1)
File size : 1.64 GiB
Duration : 1 h 44 min
Overall bit rate mode : Variable
Overall bit rate : 2 247 kb/s
Encoded date : UTC 2015-08-08 06:36:42
Tagged date : UTC 2015-08-08 06:36:42
Video
ID : 1
Format : AVC
Format/Info : Advanced Video Codec
Format profile : [email protected]
Format settings : CABAC / 4 Ref Frames
Format settings, CABAC : Yes
Format settings, ReFrames : 4 frames
Codec ID : avc1
Codec ID/Info : Advanced Video Coding
Duration : 1 h 44 min
Bit rate : 2 151 kb/s
Maximum bit rate : 13.4 Mb/s
Width : 1 920 pixels
Height : 1 040 pixels
Display aspect ratio : 1.85:1
Frame rate mode : Constant
Frame rate : 23.976 (24000/1001) FPS
Original frame rate : 23.976 (23976/1000) FPS
Color space : YUV
Chroma subsampling : 4:2:0
Bit depth : 8 bits
Scan type : Progressive
Bits/(Pixel*Frame) : 0.045
Stream size : 1.57 GiB (96%)
Writing library : x264 core 123 r2189 35cf912
Encoding settings : cabac=1 / ref=4 / deblock=1:-1:-1 / analyse=0x3:0x133 / me=umh / subme=9 / psy=1 / psy_rd=1.00:0.15 / mixed_ref=1 / me_range=24 / chroma_me=1 / trellis=2 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=0 / chroma_qp_offset=-3 / threads=48 / sliced_threads=0 / nr=0 / decimate=1 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / bframes=3 / b_pyramid=2 / b_adapt=2 / b_bias=0 / direct=3 / weightb=1 / open_gop=0 / weightp=2 / keyint=250 / keyint_min=23 / scenecut=40 / intra_refresh=0 / rc_lookahead=60 / rc=2pass / mbtree=1 / bitrate=2151 / ratetol=1.0 / qcomp=0.60 / qpmin=0 / qpmax=69 / qpstep=4 / cplxblur=20.0 / qblur=0.5 / vbv_maxrate=31250 / vbv_bufsize=31250 / nal_hrd=none / ip_ratio=1.40 / aq=1:1.00
Encoded date : UTC 2015-08-08 06:36:42
Tagged date : UTC 2015-08-08 06:36:51
Color range : Limited
Color primaries : BT.709
Matrix coefficients : BT.709
Codec configuration box : avcC
Audio
ID : 2
Format : AAC LC
Format/Info : Advanced Audio Codec Low Complexity
Codec ID : mp4a-40-2
Duration : 1 h 44 min
Bit rate mode : Variable
Bit rate : 93.7 kb/s
Maximum bit rate : 102 kb/s
Channel(s) : 2 channels
Channel layout : L R
Sampling rate : 48.0 kHz
Frame rate : 46.875 FPS (1024 SPF)
Compression mode : Lossy
Stream size : 70.2 MiB (4%)
Language : English
Encoded date : UTC 2015-08-08 06:36:51
Tagged date : UTC 2015-08-08 06:36:51
When increasing rate (ctrl up/down) the voices quickly become sounding like a chipmunk.
Could increasing the rate not affect audio? Just like in Youtube, increasing the speed doesn't pitch up the audio.
Thanks...
I have created this special video in the following way:
First original SRT subtitle entry:
1
00:00:00,001 --> 00:00:02,000
1...
Actual behaviour:
Expected:
Extra information:
P.S. I've tried to post the issue to the official bug tracker but I was blocked by the Cloudflare guard with the message Sorry, you have been blocked. You are unable to access mpc-hc.org
, so I posted it here.
Firstly, thanks for your work on keeping this project alive. Much appreciated!
If you try to open a private video or playlist (consider that you can access it yourself, using your YouTube account) with MPC-HC, you will get this message: "ERROR: This playlist is private, use --username or --netrc to access it.". Trivial to do so otherwise, externally, but I didn't find a way to make MPC-HC pass it, so an option to pass username and password should be added, or an option to pass custom extra parameters altogether . Should probably just add the latter (or maybe both possibly) since I see youtube-dl can accept many options that could be vital for some user in the same vein, such as more authentication options or even specific --video-password for a few non-YT sites, not to mention that the other non-auth stuff params can be useful as well. Thinking of it, this in turn means there should be a new command line switch for MPC-HC itself, to pass extra arguments to youtube-dl in this call (possibly replacing the ones in settings?), so it can be done when you open a remote file from a command-line/shortcut, and so you can even control the parameters used per-file. A user having different passwords for non-YT sites could also be a thing. I don't know how feasible as of right now it would be to have MPC-HC itself by default prompt for a username and password when necessary, with a dialog. Might require collaboration with youtube-dl dev if it's something you want to bother with at all.
Relatedly, you could allow all such youtube-dl configuration I mention here to be loaded from a new text file (e.g. something similar to a .ini or .cfg file) in the MPC-HC directory, in which the user could add an arbitrary amount of any global and per-site/domain/even video specific youtube-dl options himself, not just passwords. There might be a domain match or regex string given to match the whole video URL to a specific settings set.
I guess it's worth noting it is a sort of security risk in that a user doing this exposes his (or the one that is used, anyway) Google/whatever account password in plaintext in settings storage or visibly in the MPC-HC settings dialog (unless you specially implement a workaround here like store it encrypted and not visible in the dialog once saved) and so the account is potentially vulnerable provided another person can already locally or remotely access his computer, but that's the user's own choice... I would use this feature. If it's not implemented by the user editing or creating a text file manually approach (in which case the risk should be immediately obvious) and no encryption is used then it might or might not be a thing worth including a warning about, though.
Apparently you can pass --username without passing --password as well to make youtube-dl ask for it interactively, so that might also be a usable thing, though a "remember" feature would still be needed all the same.
Of course, the only trivial/non-sidetracking and very-quick-to-add feature I've mentioned above is a basic extra-parameters-to-pass-to-youtube-dl-by-default new option and extra-parameters-to-pass-to-youtube-dl new command line switch, so I'd understand if you simply only add those, or only those at first. It'd probably be smart and still easy to make those two options able to replace the entire parameter string MPC-HC passes instead (using a replacement string to be swapped with the URL provided to MPC-HC, in the default-option), in case the built-in one might interfere with some possible customization options that could come after, it such as the desired video quality/format to use or something.
By the way, could the "File->Save a Copy..." function be expanded to still be available while a youtube-dl video is opened, and be used to... save or download the video using youtube-dl? Could be a pretty useful shortcut.
Thanks for reading.
Opening URL (YT Videos) does not obey option "Keep history of recently opened files" and url is added to Recent Files even when option is unchecked.
PS: Save Image does not set default name (blank instead) for YT videos.
v1.8.1
Here's the original ticket that documents this issue. This is especially a problem when taking screenshots of DVDR sources like VOB files which get stretched out beyond the original aspect ratio when you take a screenshot. VLC and mpv do not have this behavior when taking screenshots of the same files and it's time MPC-HC also meets this standard.
https://trac.mpc-hc.org/ticket/46
It might be too late to fix this at this point but now that this project is on github, perhaps somebody out there can finally submit a pull request that fixes this.
I was able to build 1.7.18
just fine but with addition of libaom
this is not the case anymore.
command that i'm running is build.bat build x64 7z
mpc-hc_errors_Release_x64.log:
09:58:16.995 33>EXEC : error : aom >= 0.1.0 not found using pkg-config [g:\devel\mpc-hc\src\thirdparty\LAVFilters\LAVFilters.vcxproj]
09:58:17.079 33>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.MakeFile.Targets(44,5): error MSB3073: The command "build_lavfilters.bat Build x64 Release Silent Nocolors" exited with code 1. [g:\devel\mpc-hc\src\thirdparty\LAVFilters\LAVFilters.vcxproj]
looking around for the same error i've discovered that the issue is because of order of the building but i can't provide a patch being that i don't know how to fix this.
With ripped media that contain soft subtitles, where the subtitle track is shorter than the length of the video track (e.g. foreign language parts), MPC-HC doesn’t respect the end times of the last subtitle. The last subtitle entry remains on the screen for the rest of the video.
First of all, I just wanted to say thank you for updating the best video player available on Windows!
Just upgraded MPC-HC from the last official release (1.7.13.0 32 bit) to your latest release (1.8.2.0 x64) on Windows 10 build 17134.285, and I found an issue that was not present in the last official release.
I use the following MPC-HC Playback -> Output settings that have always worked wonderfully so far (see images below):
Playback is still working fine the first time when entering fullscreen using Alt + Enter or window double click, however, if I try to enter fullscreen playback again from windowed mode, no video is visible. Something is displayed as fullscreen but not visible (see the image below) at this point since I can start and stop playback (audio starts and stops) by clicking on the unfocused MPC-HC window, and pressing ESC returns MPC-HC to normal with the video visible again.
This issue prevails until MPC-HC is restarted or another video is selected for playback, also, the issue is not present if Windows 10 Compatibility -> "Disable fullscreen optimizations" is disabled.
This is not a major issue and I can provide more information if needed. I can also help test any fixes if you think this is an easy bug to find.
This only happens when using Internal Subtitle Renderer, madVR and PGS subtitles AFAIK. When the video doesn't fill the whole screen and madVR is configured to move the subtitles into active video area, the subtitles appear squished horizontally.
Move subtitles into active video area OFF:
Move subtitles into active video area ON:
Thanks for keeping this project alive!
Is there an option to disable video pause on left mouse click?
Thanks.
Jump backward (Shift+left arrow) doesnt jump backward as forward does , instead it jumps only one frame back. Holding it for more than 2 seconds only jumps , but it jumps too much.
If I leave a video paused for several minutes or more (10+?) and resume I get nothing but noise/distortion for audio. Switching audio tracks (assuming there is more than one) fixes it as does exiting and restarting the video. I noticed my AVR shows PCM when this occurs (prior to pausing audio was DTS/DD (bit-streaming)). Windows Pro 10 with latest mpc-hc and external lav decoder.
Yes, I'm sure that you recognized the description, clsid2.
It's a duplicate of my report here:
https://trac.mpc-hc.org/ticket/6067/
I noticed that you elevated that ticket to "high priority" some time ago.
Any chance of you including a fix for this particular issue in your next release?
Preferably, MPC-HC shouldn't try to connect to the internet when no subtitle providers are selected.
And of course, no providers should be selected by default, thereby preventing any accidental connection attempts!
Thanks a lot for continuing the work on MPC-HC! :)
https://github.com/mpc-hc/rarfilesource needs updating to play files zipped with RAR5 , which is refered to as just RAR now . The update should detect Rar4 and Rar5 and play from the archive
Since moving from 1.7.13 to 1.8.1 on Windows 7 Ultimate 64-bit, I've found that DVD playback no longer works -- MPC-HC gets stuck in an infinite loop after opening the disc. For me the issue is 100% reproducible regardless of disc (I tried several). I also tried with a fresh/empty mpc-hc64.ini; no difference. Reverting back to 1.7.13 fixes the problem.
Methodology:
If there's anything I can do to help debug the issue, let me know. Thank you!
On amd drivers since 17.12 version when enhanced sync is turn on on global settings video is stuttering on mpchc playback no metter what setting is set on lav filters. When that setting is turn off all is ok. It doesnt concern other video players so is mpchc 100% related
Hi
Most of the time, after of start the operative system (Win7 x64) and play a file from explorer (with double-click), it hangs (it doesn't respond) for several seconds, and then it play it. I notice it at least since 1.7.13, and a couple of weeks ago I updated to the last version, but still the bug is there.
Cheers
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.