conorwilliams / libfork Goto Github PK

The Performance section in the readme doesn't have any timings provided, while the paper is absolutely unreadable because it's written in academic matters: formulas, coefficients, etc.
It would be great to have simple timings for simple developers that just want to use the library and want to have practical comparison in nanoseconds or CPU cycles: how much it takes to construct the task body, how much it takes for the task worker thread to pick up the task.

Think of comprehensive benchmarks like here: https://github.com/SergeyMakeev/ExcaliburHash

P.S. anyway, thanks for the amazing work!
I was thinking about such a library some time ago and found this. That's amazing!

Hi, I've just discovered this potential gem. But to be sure the features reflect in practical setting, we'd need to test it first.

Do you have any such performance benchmarks (even if not rigorous...)?

I'd be mostly interested in direct comparison with Nim's Weave which I myself consider as state-of-the-art library. So ideally the benchmarks could be aligned with Weave's ones 😉.

Thoughts?

Hi, when I'm trying to compile the program, I was having the same issue as mentioned in Can't compile with glibc master (future 2.34): SIGSTKSZ is no longer a constant. I was trying to update the doctest version into 2.4.6 but was having this error:

Would appreciate it very much if anyone can give me some advice on how to fix this. Thanks!

I managed to get the benchmark suite to run on an AWS c7g.16xlarge instance running Ubuntu 22.04, built with Clang 15 (with Release build type), with the machine otherwise quiet. Benchmarks were done on 8dd4984 (current tip of tree).

See the attached log: results.txt

On Ubuntu 22.04 running on a c7g.16xlarge AWS instance with Clang 15, I get the following error following HACKING.md:

CMake Error at /usr/share/cmake-3.22/Modules/CMakeTestCXXCompiler.cmake:62 (message):
  The C++ compiler

    "/usr/bin/clang++-15"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /home/ubuntu/libfork/build/dev/CMakeFiles/CMakeTmp

    Run Build Command(s):/usr/bin/ninja cmTC_1185a && [1/2] Building CXX object CMakeFiles/cmTC_1185a.dir/testCXXCompiler.cxx.o
    FAILED: CMakeFiles/cmTC_1185a.dir/testCXXCompiler.cxx.o
    /usr/bin/clang++-15   -Wno-assume -D_FORTIFY_SOURCE=3 -fstack-protector-strong -fcf-protection=full -fstack-clash-protection -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -Wcast-qual -Wformat=2 -Wundef -Werror=float-equal -Wshadow -Wcast-align -Wunused -Wnull-dereference -Wdouble-promotion -Wimplicit-fallthrough -Wextra-semi -Woverloaded-virtual -Wnon-virtual-dtor -Wold-style-cast  -std=c++20 -MD -MT CMakeFiles/cmTC_1185a.dir/testCXXCompiler.cxx.o -MF CMakeFiles/cmTC_1185a.dir/testCXXCompiler.cxx.o.d -o CMakeFiles/cmTC_1185a.dir/testCXXCompiler.cxx.o -c /home/ubuntu/libfork/build/dev/CMakeFiles/CMakeTmp/testCXXCompiler.cxx

The following change allows it to build:

diff --git a/CMakePresets.json b/CMakePresets.json
index 3134d07..c173de0 100644
--- a/CMakePresets.json
+++ b/CMakePresets.json
@@ -61,7 +61,7 @@
       "name": "flags-linux",
       "hidden": true,
       "cacheVariables": {
-        "CMAKE_CXX_FLAGS": "-Wno-assume -D_FORTIFY_SOURCE=3 -fstack-protector-strong -fcf-protection=full -fstack-clash-protection -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -Wcast-qual -Wformat=2 -Wundef -Werror=float-equal -Wshadow -Wcast-align -Wunused -Wnull-dereference -Wdouble-promotion -Wimplicit-fallthrough -Wextra-semi -Woverloaded-virtual -Wnon-virtual-dtor -Wold-style-cast",
+        "CMAKE_CXX_FLAGS": "-Wno-assume -D_FORTIFY_SOURCE=3 -fstack-protector-strong -fstack-clash-protection -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -Wcast-qual -Wformat=2 -Wundef -Werror=float-equal -Wshadow -Wcast-align -Wunused -Wnull-dereference -Wdouble-promotion -Wimplicit-fallthrough -Wextra-semi -Woverloaded-virtual -Wnon-virtual-dtor -Wold-style-cast",
         "CMAKE_EXE_LINKER_FLAGS": "-Wl,--allow-shlib-undefined,--as-needed,-z,noexecstack,-z,relro,-z,now",
         "CMAKE_SHARED_LINKER_FLAGS": "-Wl,--allow-shlib-undefined,--as-needed,-z,noexecstack,-z,relro,-z,now"
       }

Your findhwloc CMake script doesn't work on my environment. I get this output:

[cmake] -- Could NOT find HwlocLibfork (missing: HwlocLibfork_INCLUDE_DIRS) (found suitable version "2.9.0", minimum required is "2.5.0")
[cmake] -- Found hwloc 2.9.0 in :hwloc
[cmake] CMake Warning at CMakeLists.txt:87 (message):
[cmake]   HWLOC not found, NUMA support disabled!

It seems to be failing to find the include file. I'm using Debian 12. My hwloc is installed as a system package, and the include file is in the most usual place...

➜  ~ ls /usr/include | grep hwloc.h
hwloc.h
➜  ~ sudo apt install libhwloc-dev
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
libhwloc-dev is already the newest version (2.9.0-1).

My substantially less complex script seems to find the library and include file just fine.