GithubHelp home page GithubHelp logo

Comments (1)

emiln avatar emiln commented on July 1, 2024

It seems we prematurely closed this issue. Having tried to use it for Demonology, I have the following remarks:

  • GetCastTime throws an error when querying a non-existing spell.
  • RemainingDuration throws an error in all of the following cases:
    1. RemainingDuration("Curse of the Elements", "target") – with the target affected by it.
    2. RemainingDuration("Curse of the Elements", "target") – with the target not affected by it.
    3. RemainingDuration("Dark Intent", "player") – with the player not affected by it.

All errors are: (attempt to perform arithmetic on local 'expires' (a nil value))

In other words, it doesn't work at all for debuffs, and asking about a non-present buff or spell will throw an error. A null check will surely avoid the errors, but we may have to divide this into RemainingBuffDuration and RemainingDebuffDuration. I recall making exactly this choice for BuffActive and DebuffActive due to UnitAura acting up.

from protipper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.