Comments (1)
It seems we prematurely closed this issue. Having tried to use it for Demonology, I have the following remarks:
GetCastTime
throws an error when querying a non-existing spell.RemainingDuration
throws an error in all of the following cases:RemainingDuration("Curse of the Elements", "target")
– with the target affected by it.RemainingDuration("Curse of the Elements", "target")
– with the target not affected by it.RemainingDuration("Dark Intent", "player")
– with the player not affected by it.
All errors are: (attempt to perform arithmetic on local 'expires' (a nil value))
In other words, it doesn't work at all for debuffs, and asking about a non-present buff or spell will throw an error. A null check will surely avoid the errors, but we may have to divide this into RemainingBuffDuration
and RemainingDebuffDuration
. I recall making exactly this choice for BuffActive
and DebuffActive
due to UnitAura
acting up.
from protipper.
Related Issues (20)
- DebuffRefresh nil value comparison
- New look and feel HOT 1
- Error handling HOT 2
- Visual notification when target is out of range HOT 1
- Boss-to-boss info. HOT 3
- Visual representation of alternative power types
- TOC is out of date
- Font mismatch in spellname versus hotkey. HOT 2
- Making features optional HOT 1
- Inquire about pet family
- Back on track HOT 1
- Describe the API in the README
- Split GUI code into separate file
- Add ability to query combo points
- Update the image in the README HOT 1
- Add "full duration" to API.Effect
- Warlock Affliction: Reapply Soul Drain as soon as the second-last tick has occurred
- Warlock Affliction: Apply all dots with Soulburn
- Bring TOC up to date
- Warlock Affliction: Grimoire of Sacrifice
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protipper.