emiln / protipper Goto Github PK

This is currently just a stub.

I need these functions to update the Fire Mage priority list and possibly other lists in the future. I am under the impression these functions could be useful further along.

This is currently just a stub.

The TOC currently contains such information as:

## Interface: 50001
## LastUpdate: 2012-11-03T22:00:00Z
## Version: 1.0.0

This clearly needs updating.

As a user of Protipper, I would like to notice when my target is out of range. It would be nice if the spell icon took on a red hue when then this happens. Ideally it should be calculated based on the range of the recommended spell.

As a user of Protipper, I would like to keep track of my Soul Shards, Burning Embers, or Demoic Fury, so I would like this information to be available from the Protipper UI.

I think it could be displayed succinctly by adding a horizontal bar on top of the icon.

As an author of priority lists, I would like to be able to answer such questions as "is the current pet a Felguard or Wrathguard"?

As an author of priority lists, I find it confusing that a failure in my priority lists results in Protipper.lua throwing an error. This is misleading, and it makes debugging very cumbersome.

This is a syntactically invalid part of a priority list:

{ "Dark Soul",
  "p.AbilityReady('Dark Soul'" },

It produces the following error:

It is not clear that my priority list is even remotely involved in the error. It would be nice to handle errors in priority list author code more gracefully.

If the player has chosen the Grimoire of Sacrifice talent, Protipper should figure out to suggest summoning and then sacrificing a pet if the buff has expired. Which pet remains an open question.

As a user of Protipper, I may not want to see anything beyond the ability to use. I may have other addons taking care of displaying health bars, alternative power types, etc.

It would be nice if these features could be turned on or off at my leisure.

Abilities like Drain Soul tick 4 times during their total channel duration. It would be nice to be able to express a condition like "the second-to-last tick has occurred", which is equivalent to the remaining time being less than a fourth of the total time.

It seems like player cast temporary weapon enchants are not reckognized as buffs and therefore doen't proceed to the next step in the rotation.

http://wowprogramming.com/docs/api/GetWeaponEnchantInfo - Might help in solving this problem.

The project has been dead for the duration of my World of Warcraft hiatus. After great peer pressure from friends and a cripplingly weak backbone on my part, I am now back. I see the following requirements to getting the project back on track:

• Make it load without errors.

This should go without saying. The API has apparently changed and the Addon no longer works at all. The first (of possibly many) errors is: Interface\AddOns\Protipper\Protipper.lua:143: attempt to call global 'GetNumTalents' (a nil value)

• Ditch the string-based priority lists in favor of anonymous functions.

The original reason for going with strings was that it seemed easier for newcomers to grasp. While a dubious claim at best in retrospect, the newcomer ease or difficulty of the approach is rendered entirely moot by the lack of involved newcomers. We should switch to the approach I've been taking with Protipper Rift instead.

• Ditch the awkward forced boolean return type on API functions.

Rather than ComboPoints(5, 5) I would really prefer to just write ComboPoints() == 5 in my priority lists. This rather bothersome API choice was made for reasons similar to the string-based approach, and I really don't like it.

This is currently just a stub.

Demonology is completely out of touch with recent changes.

I'd suggest claiming the following:

## Interface: 60200
## Title: Protipper
## Notes: A helping hand in keeping track of your DPS rotation.
## Author: Ethrain, Binky
## LastUpdate: 2015-08-22
## Version: 0.1.0

Perhaps we should add an email address for each of us as well. As far as I can tell, most people use ## X-Email: ... for that.

Let's be honest. The UI currently isn't a looker. As a user of Protipper, I want it to conform to current design trends, and I suggest that:

• Backgrounds are completely black, but slightly transparent.
• Borders are 1 pixel wide solid black without shadow, blur, rounding, or transparency.
• Font is white (like in ability tooltips).

This is currently just a stub.

As a user of Protipper, I would like to see the current key binding, if any, for the suggested ability to use. It would be nice to display it on top of the icon in a fashion similar to how the default Blizzard action bars do it.

While trying to make a priority list for Shamans, it became quite an obstacle to incorporate totems in the list. Here's why:

While Searing Totem is active for approx 1-2 min. it is not always doing dps. If the mob is more than 40 yards away, it cannot fire. Therefore I would like some function that knows where the wards are, for how long they are active (Less than 15 sec would prompt it to suggest to lay a new totem, while 1 min will suggest totemic projection), and suggests a totemic projection accordingly.

The README file should have a section describing the new API we supply to the condition functions in the priority lists.

This priority lists works, but isn't optimal.

This is currently just a stub.

This is currently just a stub.

The priority lists works, but is rather basic.

This is currently just a stub.

Destruction is missing a few minor touches to be completely raid-ready.

If you have 4 soul shards and the target has 0 of your 3 dots applied, it seems the general consensus to use Soulburn + Soul Swap to apply your dots.

It would be nice to separate at least the GUI code into its own code file. It takes up a lot of lines and it generally unpleasing to behold.

Testers were not impressed with the current suggestions.

It seems commonly agreed upon that this is the proper way to refresh it. With #72 completed, this should be very easy to express. Something like:

effect.remainingDuration < (effect.totalDuration / 4)

it is possible to cause DebuffRefresh to cause a nil comparison error:

DebuffRefresh('Shadowflame', 'taget') will fail, despite Shadowflame being a valid debuff, because the function will fail to retrieve its cast time (as it isn't also a spell). Clearly, the function should use a cast time of 0 in this case.

This was halfheartedly implemented with Kardeth back in the days.

This is currently just a stub.

This was halfheartedly implemented with Kardeth back in the days.

As a user looking at the hotkey text and the spell name, my eyes bleed. I wish for this to be remedied immediately. (As I, surprisingly enough, dislike bleeding from my eyes)

This is currently just a stub.

The priority list currently works like this:

• Curse of the Elements
  • If neither of the following debuffs are on the target:
    • Curse of the Elements
    • Lightning Breath
    • Master Poisoner
• Dark Soul
  • Whenever it's ready.
• Summon Doomguard
  • Whenever it's ready.
• Soul Swap
  • If Soulburn is active on the player.
• Soulburn
  • If full on Soul Shards and at least one of the following is true:
    • Agony will benefit from being refreshed.
    • Corruption will benefit from being refreshed.
    • Unstable Affliction will benefit from being refreshed.
• Agony
  • If Agony is about the expire.
• Corruption
  • If Corruption is about to expire.
• Unstable Affliction
  • If Unstable Affliction is about to expire.
• Haunt
  • If Haunt will benefit from being refreshed and at least one of the following is true:
    • Dark Misery is active on the player.
    • The player is full on Soul Shards.
• Drain Soul
  • If the target is below 20% health.
• Life Tap
  • If the player is below 20% mana.
• Malefic Grasp
  • Whenever it's ready.

It generally favors keeping 4 Soul Shards until it detects a favorable moment (currently meaning Dark Soul.)

This was halfway implemented for low level Elemental Shamans.

This is currently just a stub.

An addon in the menu, easily turned on and off.

Information about the spec best suited for which encounter.

PS. emiln is a douche.

This is currently just a stub.

The current image clearly shows the old version with health bars and a character wearing Mists gear. It would suit the README to provide up to date images of the Addon.

This is currently just a stub.

In anticipation of asking Andy to help me write a feral druid priority list, it seems necessary to be able to query the number of combo points currently amassed by the player. I suggest we add it to the return table of API.Status(). It's a pretty simple addition, so the question is mainly where it should reside in the API.

This is current just a stub.

This is currently just a stub.