GithubHelp home page GithubHelp logo

core-item's People

Contributors

addyosmani avatar cletusw avatar dfreedm avatar ebidel avatar frankiefu avatar nevir avatar sorvell avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

core-item's Issues

core-item should have a "value" property

The core-item should have a "value" property along with the "label" property. It would be nice to be able to attach a value when using the core-item in lists. For example, in a core-dropdown-menu or paper-dropdown-menu.

"Separator" version?

Is there a way to indicate an item (in a menu, for example) is a separator? Or do I have to style it manually (disabled, etc.)

Why ::content > a { position: absolute } ?

This means that any tag within the will be not have its height and width taken into account when laying out the item.

In my use case I have a . And within it I have an tag with text like 'veerrryyy loooonnng tttexxxttt ssttring'. And because the position is absolute the width is not taken into account. This means the 's width is short than the 's width, causing obvious design problems.

I have hacked a fix like this:

core-item /deep/ a {
     position: relative !important;
}

Obviously this is not idea. Can we not remove the position: absolute in the core-item?

Incorrect core-icon-button styling under the polyfill

https://github.com/Polymer/core-item/blob/master/core-item.css#L26

This makes the core-icon button to be incorrectly shaped in Firefox 31 - margin left and right are different and the button looks strange (wider on the right).

I had to override this in my app element with:

      :host /deep/ core-item /deep/ core-icon {
        margin: 0 0 0 0 ! important;
      }

Why is this put in there, does it provide any functionality? If yes, should it be tested under the polyfill?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.