GithubHelp home page GithubHelp logo

Add explicit module-info about micrometer HOT 3 OPEN

bowbahdoe avatar bowbahdoe commented on August 16, 2024 2
Add explicit module-info

from micrometer.

Comments (3)

bowbahdoe avatar bowbahdoe commented on August 16, 2024 1

This isn't possible without a new major version. I don't foresee that happening anytime soon.

Ways 2 or 3 it is.

Isn't a prerequisite of adding an explicit module-info.java that all dependencies we declare have at least an automatic module name? In micrometer-core, I see our dependencies don't:

Okey dokie. Further into the mines I go.

I opened a PR on HDR histogram. Its last release was 4 years ago and they do have an automatic module name in their POM so maybe there just hasn't been a release since that.

After that, LatencyUtils (since it depends on HdrHistogram) https://github.com/LatencyUtils/LatencyUtils

A non-trivial part will be having those folks make maven central releases too.

We will have the same issue with some of the registry modules that have external dependencies.

One thing at a time I guess.

from micrometer.

giltene avatar giltene commented on August 16, 2024 1

@bowbahdoe HdrHistogram 2.2.1 is now released to maven central with your PR integrated. I can also do the same to LatencyUtils if you open a PR there.

from micrometer.

shakuzen avatar shakuzen commented on August 16, 2024

Bump the entire project to a higher Java version.

This isn't possible without a new major version. I don't foresee that happening anytime soon.

Isn't a prerequisite of adding an explicit module-info.java that all dependencies we declare have at least an automatic module name? In micrometer-core, I see our dependencies don't:
image
We will have the same issue with some of the registry modules that have external dependencies.

from micrometer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.